hsiaocy / beads Goto Github PK

Hi,
I used beads function on Matlab and it works perfectly.
After that I needed to translate the code in Python and this function doesn't work as Matlab ones.

I attach two screenshots of the same input, with two different output.

matlab comparison

Python comparison

I tried to use the test() method and instead of this:

sig = np.cos(2*np.pi*7*t) + np.sin(3*np.pi*7*t+300*t)

I entered my chromatogram. But in the end the original signal and the result are almost the same. Do I need to tune the params? I don't understand the math behind it yet, so I was hoping that the algorithm would "just work".

Here are these chromatograms in 1 plot (you see only 1 line because they are very similar):

And here is plt.plot(domain, sig - x.squeeze(), 'g'):

稀疏矩阵阵列对内存要求过高，5W个点的数据需要超过8G内存，在普通配置电脑上运行时，提示内存分配错误。
numpy.core._exceptions.MemoryError: Unable to allocate array with shape (50175, 50176) and data type float64

Hello,
I think you make a mistake in your function return value arrange in Line 167. Your code is x, f, cost = beads(y=sig, d=d, fc=fc, r=r, lam0=lam0, lam1=lam1, lam2=lam2). But refer from the definition in Line 101, it should be x, cost, f = beads(y=sig, d=d, fc=fc, r=r, lam0=lam0, lam1=lam1, lam2=lam2).