Regression with recent changes in sceIo about ppsspp HOT 8 CLOSED

Mmm, I left the code paths as they were, mostly. I'll have a look at it.

from ppsspp.

See also here: http://forums.ppsspp.org/showthread.php?tid=284
for similar error in sceIoWaitAsyncCB

from ppsspp.

Well, I'll restore the changes to their previous state then. Seems that I broke async functions. Can you tell me please if you got the same error back when it worked?

E[HLE]: ERROR - sceIoPollAsync waiting for invalid id 32

What's the emulator behaviour? Does it stop, close suddenly? It just seems strange to me that the little change I did could have something to do with the error message (If it crashes, it would be because I omit one thing it should be there)

from ppsspp.

Don't revert, the change is mostly good. Fix the bugs you introduced instead, I think unknownbrackets has the right diagnosis in his comment - you're throwing away return values that were previously set with RETURN in cases where a HLE function calls another one that you have now converted to use "proper" returns.

If you can't figure it out, reply here and I'll do it for you.

I hope to find a way to reduce these pitfalls :P

from ppsspp.

I understand, the thing is to get an elegant fix. Maybe just returning the value the inner fuction directly in the call... I think I should've called the wrapped function insted, but since the array is not accessible (to do the call with a reference to it), I thought it would have been ugly to use the templated call directly. I have 2 options:

Return directly the value once the function is called.
or
Use the wrapper directly.

An stupid mistake indeed.

It's not really a pitfall. I should have paid more attention.

from ppsspp.

I think the whole fix is basically, in sceIoOpenAsync:

RETURN(sceIoOpen(....));

instead of

sceIoOpen(....)

which throws away the return value.

Unlike the other async functions, it seems sceIoOpenAsync should return the UID directly.

from ppsspp.

I've done just that. I'm very bad explaining things. Really bad.

from ppsspp.

Yes, I didn't see that you had actually done the fix before I posted :)

from ppsspp.