Build error with miniupnpc 2.2.8 (changed API for UPNP_GetValidIGD) about ppsspp HOT 10 CLOSED

I'm confused, doesn't seem like this API change has been made part of an official release of miniupnp yet? Hm, the change was in may and our fork was updated in june?

We should probably just upgrade our forked version, and do this change without the ifdef, when it's time.

from ppsspp.

I'm confused, doesn't seem like this API change has been made part of an official release of miniupnp yet?

Already included in 2.2.8 release. Yes, it's API breakage in patch level update: 2.2.7 → 2.2.8. 👎

Hm, the change was in may and our fork was updated in june?

2.2.8 released month ago: https://github.com/miniupnp/miniupnp/releases/tag/miniupnpc_2_2_8

We should probably just upgrade our forked version, and do this change without the ifdef, when it's time.

Maybe. But the FreeBSD port emulators/ppsspp uses external miniupnpc from port net/miniupnpc.

from ppsspp.

Ok, I guess I'll just apply the patch with the version check then. Ugly.

from ppsspp.

Alright, PR submitted: #19335

from ppsspp.

You don't need old comment about status values.

from ppsspp.

Also status never used after call UPNP_GetValidIGD.

from ppsspp.

I thought you wanted to add it for some reason since it was included in your patch above.

Yeah, should probably check it. I'll just log it out for now. I didn't write that code, heh.

from ppsspp.

I said about this line:
- int status = UPNP_GetValidIGD(devlist, urls, datas, lanaddr, sizeof(lanaddr)); //possible "status" values, 0 = NO IGD found, 1 = A valid connected IGD has been found, 2 = A valid IGD has been found but it reported as not connected, 3 = an UPnP device has been found but was not recognized as an IGD

from ppsspp.

ooh, I misunderstood, heh. Will restore it.

from ppsspp.

Thanks!

from ppsspp.