Comments (10)
I'm confused, doesn't seem like this API change has been made part of an official release of miniupnp yet? Hm, the change was in may and our fork was updated in june?
We should probably just upgrade our forked version, and do this change without the ifdef, when it's time.
from ppsspp.
I'm confused, doesn't seem like this API change has been made part of an official release of miniupnp yet?
Already included in 2.2.8 release. Yes, it's API breakage in patch level update: 2.2.7 → 2.2.8. 👎
Hm, the change was in may and our fork was updated in june?
2.2.8 released month ago: https://github.com/miniupnp/miniupnp/releases/tag/miniupnpc_2_2_8
We should probably just upgrade our forked version, and do this change without the ifdef, when it's time.
Maybe. But the FreeBSD port emulators/ppsspp uses external miniupnpc from port net/miniupnpc.
from ppsspp.
Ok, I guess I'll just apply the patch with the version check then. Ugly.
from ppsspp.
Alright, PR submitted: #19335
from ppsspp.
You don't need old comment about status
values.
from ppsspp.
Also status
never used after call UPNP_GetValidIGD
.
from ppsspp.
I thought you wanted to add it for some reason since it was included in your patch above.
Yeah, should probably check it. I'll just log it out for now. I didn't write that code, heh.
from ppsspp.
I said about this line:
- int status = UPNP_GetValidIGD(devlist, urls, datas, lanaddr, sizeof(lanaddr)); //possible "status" values, 0 = NO IGD found, 1 = A valid connected IGD has been found, 2 = A valid IGD has been found but it reported as not connected, 3 = an UPnP device has been found but was not recognized as an IGD
from ppsspp.
ooh, I misunderstood, heh. Will restore it.
from ppsspp.
Thanks!
from ppsspp.
Related Issues (20)
- "Upnp needs to be Reinitialized" and "Failed to offset port 555" HOT 10
- Fails to build retroarch core with gcc-14 HOT 3
- ppsspp 32 bit HOT 2
- Feature request: exit back to frontend HOT 5
- Choosing a scripting language HOT 8
- Disabling plugins and closing the emulator re-enable them HOT 5
- Textures Folder Has Permissions on Android TV HOT 22
- Bad symlink in vulkan ext subdir
- Akiba's Trip Plus little sister from the future HOT 1
- Syphon Filter: Remaining lighting problem (HW/SW transform difference)
- Need better handling of out-of-memory conditions when using texture replacement
- compile for aarch64 target,ld error undefined reference to `CpuFeatures_GetHardwareCapabilities' undefined reference to `CpuFeatures_IsHwCapsSet' HOT 3
- Reports of plugins not working correctly HOT 1
- Java Exception Error HOT 8
- porting to arm-linux RUN ERROR: EGL Error EGL_BAD_NATIVE_WINDOW detected HOT 8
- psspp vr with oculus quest 3 after updated v69 oculus - black screen or 3 dots, no loading HOT 5
- Android 11 Google TV - MI TV 2nd Gen HOT 1
- Logging problems when calling syscalls from other syscalls
- Single Threaded Option, TAS Purpose
- Add an optional feature to let the PPSSPP software renderer simulate the feeling of 90s PC native game's software renderer HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ppsspp.