Giter Club home page Giter Club logo

swift-google-maps-api's Issues

Why requirement iOS 9.0+

Hi,

Your lib is perfect because GooglePlace cannot give me open hours (grr &#!)
But why not start requirement at iOS 8.4 ?

Thx for your job

swift 3 support

it would be great if you could update it for swift 3 and Alomofire 4.0.

Please update to Xcode10

I'm getting 8 compiler errors like this:

/Google Maps Directions API/GoogleMapsDirections.swift:143:90: Cannot convert value of type '[AnyHashable : Any]' to expected argument type '[String : Any]?'

It happens in this file GoogleMapsDirections.swift

error = NSError(domain: "GoogleMapsDirectionsError", code: -4, userInfo: userInfo)

My podfile is like this:

pod 'GoogleMapsDirections', :git => 'https://github.com/honghaoz/Swift-Google-Maps-API.git', :commit => '0eb155b893366f9f9208cdf1652a1fce72926149'

Don't print the request to the console

Line 122 and 197 in GooglePlaces.swift print the request to the console and it includes the API key, which exposes the API key to anyone who can read the console.

This may happen in other files, but I only saw it in GooglePlaces.swift.

arrivalTime and departureTime support for .Driving mode

Per google api arrivalTime and departureTime can be set in driving mode to get duration with traffic.

Modify line 89 and 93 in GoogleMapsDirections.swift with:

if let arrivalTime = arrivalTime where (travelMode == .Transit || travelMode == .Driving) {

and

if let departureTime = departureTime where (travelMode == .Transit || travelMode == .Driving) {

sessionToken support for api requests

Can your pod support sending Place Autocomplete parameters, and specifically the sessionToken?
If not then would you either consider adding that feature or accepting a push if your pod was updated to support it?
Much Thanks.

APIKey Restriction

Hi, first of, great work that you're doing. The API is very simple to use.
The Issue: your api uses Google WebApi and not iOS SDK, the key restriction will not work as they are only supported in SDK version. It would be great if you can add such a feature.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.