Giter Club home page Giter Club logo

Comments (3)

will-moore avatar will-moore commented on June 13, 2024

I like the idea. Makes sense and certainly most of the plates I've seen do have identical sized images in every Well.
But it's probably too restrictive to say that ALL Plates must have all Images the same size. So we could maybe 'consolidate' that info into a parameter like "all_images_same_size" in the plate metadata?
Maybe open an issue at https://github.com/ome/ngff ?

from vizarr.

manzt avatar manzt commented on June 13, 2024

Sure, I'll look into opening an issue. It's worth noting that in order to render to the grid currently (for plate or well), we require identically sized images:

vizarr/src/gridLayer.ts

Lines 44 to 55 in 1ef2163

function validateWidthHeight(d: { data: { width: number; height: number } }[]) {
const [first] = d;
// Return early if no grid data. Maybe throw an error?
const { width, height } = first.data;
// Verify that all grid data is same shape (ignoring undefined)
d.forEach(({ data }) => {
if (data?.width !== width || data?.height !== height) {
throw new Error('Grid data is not same shape.');
}
});
return { width, height };
}

And vizarr will throw an error otherwise. So this issue is suggesting that we make that assumption initially as well, when initializing arrays.

from vizarr.

joshmoore avatar joshmoore commented on June 13, 2024

Maybe open an issue at https://github.com/ome/ngff ?

Agreed. I think we have something along the lines of "all dtypes for the multiresolutions will be of the same type" and we might could generalize that for "all items in a certain type of collection".

from vizarr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.