Giter Club home page Giter Club logo

Comments (7)

will-moore avatar will-moore commented on June 13, 2024

The "support of ROIs in ome.zarr" should be discussed on the https://github.com/ome/ngff repo.
But for the support of Shapes in vizarr, I started a PR at
#128

from vizarr.

BioinfoTongLI avatar BioinfoTongLI commented on June 13, 2024

The "support of ROIs in ome.zarr" should be discussed on the https://github.com/ome/ngff repo. But for the support of Shapes in vizarr, I started a PR at #128

Sorry, the title is indeed misleading. Amended.
Awesome! The PR looks great!

from vizarr.

will-moore avatar will-moore commented on June 13, 2024

This quickly gets more complex when you consider that you might want to provide Polygons (or other shapes) that should only appear on specific Z and T indices of a multi-dimensional image.
I guess we need to move to providing Shape objects that have optional z and t indices, but OME-NGFF will soon move to arbitrary named axes (ome/ngff#57) so that needs to be handled too!
It may be that we need OME-NGFF to come up with a spec for Shapes first?

from vizarr.

will-moore avatar will-moore commented on June 13, 2024

Created ome/ngff#73 for OME-NGFF support of Shapes.

from vizarr.

BioinfoTongLI avatar BioinfoTongLI commented on June 13, 2024

This quickly gets more complex when you consider that you might want to provide Polygons (or other shapes) that should only appear on specific Z and T indices of a multi-dimensional image.

Indeed, the actual use case that I am aiming for is to not only show polygons, but also annotations (attached metadata as pd.DataFrame maybe?) while hovering. Although, having polygon overlays is definitely good start for us!

I guess we need to move to providing Shape objects that have optional z and t indices, but OME-NGFF will soon move to arbitrary named axes (ome/ngff#57) so that needs to be handled too!

That reminds me another detail, we've been playing with Vitessce recently as well. According to my shallow understanding, Vitessce only support the ome.zarr converted using bioformat2raw<=0.2.0. Is that the case for vizarr as well? Or vizarr is always using the latest ngff release?
Asking this question because, the ROIs in ome.zarr should be already there if it was converted from ome.tiff with ROIs in omexml, right? The reason pointing to that PR is because you think it's better to be inline with the latest version of ngff, am I right?

It may be that we need OME-NGFF to come up with a spec for Shapes first?

Yes, agree - More than happy to help if I will be any useful :)

from vizarr.

will-moore avatar will-moore commented on June 13, 2024

I don't know about Vitessce I'm afraid, but we (OME) certainly aim to support the latest OME-NGFF versions in vizarr. Even if there are some new features of the spec that can't be supported in vizarr, at least it should open the image and support as much as possible.
Since we don't support ROIs in OME-NGFF yet, I don't think that bioformats2raw can preserve them (unless it is simply preserving the XML within the file somehow, but I don't think so). cc @sbesson @joshmoore

I believe Vitessce should/did support OME-NGFF v0.1. See Demos at vitessce/vitessce#816 (comment) and whole discussion there.
I just tried latest vitessce.io with the demo ?url=... Demo1 works but in Demo2 the images look black, although the data is being loaded (looking at dev tools network tab).

from vizarr.

manzt avatar manzt commented on June 13, 2024

Hi @BioinfoTongLI, thanks for opening the issue!

I don't know about Vitessce I'm afraid, but we (OME) certainly aim to support the latest OME-NGFF versions in vizarr.

Vitessce is more feature-rich compared to vizarr; however, that has meant that a combination of data-models are utilized which can be complicated to then support OME-NGFF completely. Vizarr is intended to be much more minimal, and target solely the latest OME-NGFF.

Even if there are some new features of the spec that can't be supported in vizarr, at least it should open the image and support as much as possible.

Agreed. The aim is to support as much of the latest OME-NGFF as possible. I'm somewhat purposely avoiding defining concepts that will be defined in OME-NGFF (e.g. ROIs) on their own in vizarr to avoid creating conflict of some vizarr/OME-NGFF data-model. This way an image that you can open in vizarr will also open in another tool that supports the latest OME-NGFF, and we won't run into the issue where an dataset (or parts of datasets) only opens in vizarr.

I just tried latest vitessce.io with the demo ?url=... Demo1 works but in Demo2 the images look black, although the data is being loaded (looking at dev tools network tab).

I'll need to take a closer look into this to see what is going on.

from vizarr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.