himynameisdave / git-labelmaker Goto Github PK

$ npm deprecate [email protected] "critical bug fixed in v0.7.2"
$ npm deprecate [email protected] "critical bug fixed in v0.7.2"

This will give deprecation warnings to anyone installing those versions.

The readRepo util sometimes doesn't work, because this line is not good for every type of url:
https://github.com/himynameisdave/git-labelmaker/blob/master/components/read-repo.js#L6

If I select the wrong option in the CLI, or change my mind and want to return to the previous menu, it appears the only current recourse is to CTRL+C and restart the program. This requires re-entering a token or the saved token password and navigating back through the menus.

For example, if I follow the prompts to the "Which label would you like to remove?" option, I must select at least one, and there is no way back to the previous prompt. The keys 'esc' and 'q' (two intuitive options) don't appear to have any effect. Thus, if I don't actually want to remove a label, I'm stuck in at this prompt.

(Great tool by the way, super useful!)

I'd like to map each web color to it's hex value, that way users can specify a color using a simple word instead of a hex or rgb value

Let there be a banner after you select "Add/Remove" labels, currently it's kinda meh

This is probably minor but files that are valid json don't need a json extension (or if they do that should be documented).

It seems that the .git-labelmaker.bcup is written to /usr/local/lib/node_modules/git-labelmaker, which means that I need to be a privileged user (sudo git-labelmaker) to store my token?
eg. If i dont run with sudo first, I'm prompted for my token every time.

Would not it make more sense to use some XDG directory (data or config or something) to store the token under the users home directory? Or is intended functionality? Or am I confused about something else?

Allowing the user to reset their token if they can't access the archive (a forgotten password kind of feature) would mean that they can delete the archive if it exists, and creates a new one.

It would prevent any issues similar to last night! 😛

Ability to remove current labels. So the first prompt will be "add or remove" and then list all current ones and you can select which to remove.

There should be an option to use the awesome predefined packages inside of git-label-packages

Not sure wtf is going on, but here's a log of the error:

Happened when trying to run it for the first time in like a month

One of the main pieces that would help speed up using git-labelmaker is including an option for using a package from a file as the default package to use when no input is given for Add Labels from Package. This way you can just simply use one package for all of your repos.

I'd definitely be willing to submit a PR if the maintainers think this is a good idea.

Currently if there is no token set, the main menu shows, then the user inputs their token then the process exits. Things need to rotate back to the main menu

Would be nice to alert the user that there is a new version of the package available for download

Update buttercup dependency from ~0.24.0 to latest (which is 0.37.0 at time of writing).

Tested it, and it looks like there were some significant changes as upgrading will break it git-labelmaker.

• Move some functions into modules (ie: fetchToken)
• Maybe rename 'components/' directory?
• Prompts should have their own directory for sure
• see how to reduce code clutter/make functions more pure (pure-er?)
• use a bin/ and a src/ directory, make babel compile shit to bin/ this is technically #16 so we'll call it out of scope for this issue

Crawl through the git data to learn what git api url to use.

Upgrading would allow us to use the promise-based inuirer.

Currently at 0.11.4, wanted 3.0.6.

Just a question(type), I see that most of the code refers to GitHub,
but I was wondering if you are thinking of maybe supporting GitLab as well?

P.S.: The only decent NodeJS Gitlab API wrapper I found is this one, but doesn't support labels from what I can see...

We should document it in the readme that the api call is made to the public GitHub API and will not work on a private/GH enterprise repo. git-label supports this feature however I chose to hardcore the api in because it was less overhead... eventually I would like git-labelmaker to just know/ask what api to use.

"Clear All" option would be rad. It would delete all current labels in a repo.

I think that we should change:

Create git labels from the command line using git-label!

to:

Manage your GitHub labels from the command line!

Add a confirm step before you remove labels cause you might fuck up and delete them by accident.

If a repo has no labels, then you try to create a package from labels, there is no error handling in place. Doesn't really "break", but it generates an Error.json file which is not ideal.

Inquirer just released a proper v1.0.0 based on promises. I would like to use this as it means we can get rid of our promise wrapper for prompts.

https://github.com/SBoudrias/Inquirer.js/releases/tag/v1.0.0

TypeError: Cannot read property 'url' of undefined
 at module.exports (/usr/local/lib/node_modules/git-labelmaker/bin/modules/readRepo.js:13:40)
 at Promise.all.then (/usr/local/lib/node_modules/git-labelmaker/bin/index.js:38:19)

I've a repo with dots like com.foobar.www maybe that's a Problem.
Any Idea how I can fix that?

Node 7.4.0

I think we should allow users to dump all the labels from a repository, so that they can then apply that setup to other repositories.

This is blocked by #43

This is what PR #12 ended up becoming. It's basically git-label:find sugar ☕

Hello,

I think it would be a great addition to add a list of projects using this tool. It would be like a portfolio to show to someone to convince them to use it.

What do you think?

I think it would be good to investigate Bitbucket as a potential integration.

There doesn't appear to be a "Label" system on Bitbucket that goes by the same name, however there is apparently a "components" system which works in the same way.

Bitbucket is used by a lot of people/companies with JIRA and so it would be great if we could integrate.

Like #48, this isn't a priority.

Rather than only accepting 3/6 digit hex colours, RGB colours could also be accepted as an input.

Publish to npm as 0.7.3, which is the stable release of 0.7.3-alpha.

npm v3.6.0
node v5.6.0

Running git-labelmaker, enter my password, and choose Add Labels From Package. I'm prompted for a path. I have tried all of these (test file located at each)

packages/github_labels.json
github_labels.json
.github_labels.json

contents of file

[
  { "name": "ready", "color": "#159818" },
  { "name": "blocked", "color": "#e11d21" },
  { "name": "open comments", "color": "#eb6420" },
  { "name": "proposal-discussion", "color": "#84b6eb" },
  { "name": "question", "color": "#cc317c" },
  { "name": "On Hold", "color": "#666666" },
  { "name": "Revision Needed", "color": "#bfdadc" }
]

I hope this helps solve an issue - or improve the docs! Thanks for your help.

It's been too long that there aren't any tests for this... tsk tsk tsk 👎

This package might be better/simpler to use than buttercup... unsure if it's as secure, needs investigation.

https://www.npmjs.com/package/preferences

Hello,

Nice project you got there. I just read your medium article and I think you should link it from this repo.
You can copy it and put it on the wiki. You can add an url to the Readme. As you want. 😄

Cheers,

Recently updated git-labelmaker and am now getting this error frequently. I've recreated the token multiple times now which gets it working for a few commands, but I see this message again within minutes.

To reproduce:

• set your token
• run commands (I can usually run a few in quick succession before seeing this error)
• $ git-labelmaker
• choose: use saved token
• type your master password
• See error: Failed opening archive: Error: Encrypted content has been tampered with

• [email protected]
• Sierra 10.12.1
• zsh 5.2

Not sure if this is a bug or a setup issue on my end. Hoping someone might point me in the right direction. (fwiw git-labelmaker has worked perfectly for me the better part of this year - saved me SO much time 💥 )

Ninja edit: It appears that if I ctrl+c when shown that error and restart the process, it no longer thinks the content has been tampered with.

See if we can lock that token.json file down or something, or store it as an env variable and then check it out every time?

Very least some kind of chmod so an malicious attack would have to sudo at least (?)

Tokens come and go and sometimes people fuck up and install the wrong one. Okay so there should be a parameter (-t or something) that will reset the token.

I think we should be showing a friendlier error than the "Encrypted content has been tampered with" when the user enters the incorrect password.

Would be nice to track which features of the tool users are using most often. Also error reporting would be key.

Maybe mixpanel or something

Even though coverage says 100%, we know it's not quite there... :)

Also, using mockier as suggested here might be helpful 👍

When entering your password to unlock the archived token (after you've already successfully set it), the password is displayed in plain text.

Currently with option Add Labels From Package I can only take the path from current directory, it would be awesome if I could specify path to some other directory with my labels.json or even HTTP so I can use a Gist.

I got this error when running the program

➜ ~/www/veldto.com (master) git-labelmaker
? What is your master password? *********
Failed opening archive: Error: Encrypted content has been tampered with
{ id: 'TOKEN',
  err: 'Failed opening archive: Error: Encrypted content has been tampered with' }

I think Inquirer is quite heavy and has a lot of compatibility issues. We could potentially look into another solution.

Right now everything is very ES6-entric but it would be better to do a src/ and bin/ or something where the distribution or bin/ file was run through like the babel or something. Those promises be risky.

And then also add to the docs about minimum node versions and stuff.

node -v
v6.10.1
npm -v
3.10.10
git-labelmaker
? What is your GitHub Access Token?
? What is your master password, to keep your access token secure? ******
TypeError: Cannot read property 'split' of undefined
at module.exports (/usr/lib/node_modules/git-labelmaker/bin/modules/readRepo.js:14:32)
at Promise.all.then (/usr/lib/node_modules/git-labelmaker/bin/index.js:38:19)

For now I have uninstalled git-labelmaker. It is promising though ;-)

There is an error when trying to remove labels from a repo with no labels, should instead just say "no labels to remove" and redirect to the main menu