hggeorgiev / centroui Goto Github PK

Border attributes are not changing anything in the button. Most likely because getBorderStyles is only defined but not used in the class.

The only available setters are for backgroundColor and hoverColor.

Description

Importing CentroUI components causes errors in the bundle.

Steps to reproduce

1. Start a new ReactVR project:
   react-vr init WelcomeToVR

2. Install CentroUI
   npm install centro-ui --save

3. Import and use an arbitrary component

import { CnContainer } from 'centro-ui';

//...

render( 
 <CnContainer></CnContainer>
)

Error log:

Hello
Just added to my project, followed steps but get error
error:bundling failed: ambiguous resolution: module ..../.../.../ index.vr.js tries to require react-vr, but there are several files providing this module. You can delete or fix them:
Two references to react-vr one in original and one in centro-ui/none-modules

The following code snippet, taken from the API docs:

        <CnButton
        name="Add to Cart"
        shape="circle"
        color="blue">
        <CnButton/>

placed in a clean project, results with the following in the console and a black screen:

Bundling `index.vr.js`
  Analysing...(node:75754) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 202): SyntaxError: SyntaxError /Users/hgeorgiev/vr/gavkaTest/WelcomeToVR/index.vr.js: Expected corresponding JSX closing tag for <CnButton> (22:8)

(node:75754) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js

When importing CnCard, container cannot load (hence, only black screen is seen).

index.vr.js:

import React from 'react';

import {
    CnContainer, CnCard
} from 'centro-ui';

import {
  AppRegistry,
  asset,
  Pano,
  Text,
  View,
} from 'react-vr';

export default class WelcomeToVR extends React.Component {
  render() {
    return (
      <CnContainer>
        <CnCard> // Problem occurs here ...
        </CnCard>
      </CnContainer>
    );
  }
};

Exception details:

> measureLifeCyclePerf@http://localhost:8081/index.vr.bundle?platform=vr&dev=true 11847:12
> _renderValidatedComponentWithoutOwnerOrContext/renderedElement<@http://localhost:8081/index.vr.bundle?platform=vr&dev=true 12387:16
> render@http://localhost:8081/index.vr.bundle?platform=vr&dev=true 46096:19
-----
styles is not defined

ListItem is not used for List/List View. Isn't ListItem supposed to be used as per specification when data is repeated?

Alignment is used only as a state setter in List, but not actually used in the component.

I propose we use vertical and horizontal as possible properties for alignment:

All components accept bg for background color, but only TextInput uses backgroundColor.