hedyorg / hedy Goto Github PK

When I run a code that ask a question, I get the question box on the right, if I then run a print without answering the question, the question box stays open. If I answer the question later on, the rest of the previous code is still executed

Boys love cars. But car in Dutch is auto.
Using auto in your program causes errors.

But this could be level 2 too? It is not really needed anymore once we have variables.

This is confusing to kids that already have an account! Can we change the message to say something like: ...create an account or login if you already have an account?

Requires #95 to be done first.

1. Place username as available in the client to submit within program

2. When saving program, store it in the DB. If user is not logged in, use auto-generated session id.

3. Implement GET /programs (for logged user) and GET /programs/USERNAME

• increment counter in DB (if it's not an anonymous user)
• store program in DB

Not really pretty that the output field is enlarged when a lot of lines are printed:

Input:

print "oh no"

Expected output:

oh no

Actual output:

oh)+str(no

This repo could help: https://github.com/simonwhitaker/github-fork-ribbon-css

The top right task with text:

Ask something with ask. Beware! Ask needs a name now.
Example: color is ask What is your favorite color? 

autofills the wrong text:

ask color is What is your favorite color?
print color is your favorite!

[the text is correct, the code is not, and should be "color is ask What is your favorite color?"

Thanks for the great project! While trying the website I wished I could go back one level, but there is only a button to go to the next level.

See the new "run locally" functionality that was/is being added in #120.

Run the following program:

#level 5
print Hello world!

This is an incorrect program for level 5 (it's actually a level 1 program), so we are expecting to see a parse error. However, running it and printing the full error message is a little confusing:

$ python3 hedy.py test.hedy
An error occurred: Parse
level=4           <--- 🚨THIS IS CONFUSING
parse_error=No terminal defined for '!' at line 1 col 18

print hello world!
                 ^

Expecting: {'SPACE', '__ANON_8', '_EOL'}

What's happening is that on catching a parsing mistake, the parsing is retried on a level lower:

https://github.com/Felienne/hedy/blob/b4359bf202c952fd1d946e5a91a57abcbe2991b7/hedy.py#L633-L638

However, if parsing on level 4 also fails, THAT exception is not caught again but left to bubble up to the user, which is now very confusing because the final exception the user sees is about the failing parse at level 4, instead of the failing parse at level 5.

In the dutch version of Hedy, at level 7 there is an error. Whenever you press one of the 2 buttons in the attached picture, the code that is automaticly filled in is incorrect.

It is missing de necessary tabs.

In the picture below it is shown how it should look.

From an email (Dutch)

• in niveau 5 (line 85 van de broncode) staat nievau terwijl niveau bedoeld wordt,
• in niveau 7 is de tekst bij de tweede stap in het Engels: What is 5 plus 5? i.p.v. Combien font 5 plus 5?
• in niveau 6 stel ik alleen een wijziging voor in het derde voorbeeld om beter aan te sluiten bij de eerste twee voorbeelden van dit niveau:

•    Exemple: if reponse is 20 repeat 3 times print 'hurra! ' else repeat 2 times print 'désolé! '.
  

echo or print without arguments now fail hard, we should add them to the grammar with higher prio to give a Hedy instead of Python error message

First of all: good job 👏 👏
I haven't found the license file so I don't know if this project is free (as in freedom) software or not.
I would like that you think about the possibility of releasing this project under one free and open license. You can find good information about the licenses here: https://www.gnu.org/licenses/ , and in addition, you can choose the EUPL (https://ec.europa.eu/info/european-union-public-licence_en) because it fits best with EU laws.
Thanks for all

Example code:

naam is ask wat is de naam van de hoofdpersoon
print naam doet mee aan een race hij krijgt een willekeurige auto
auto is lamborghini, ferrari, porsche, honda
print auto at random

(not sure the line endings are preserved here but it will serve as a memory aid :))

At level 4 using this program:

g is kop,munt
m is g at random
n is ask Kop of munt?
print 'Jij koos ' n
if n is m print 'Ja het is ' m else print 'nee ik had ' m

n is m never evaluates to true, whether I type the correct value or not.

Level 1, ask command:
In Spanish the official spelling is "ask Cuál es tu color favorito?". But that cannot be executed at this moment.

Two options:

1. Allow á, é and ó as this is used in all Spanish questions (qué, cuál, quién, cómo, cuán, cuánto, cuándo, dónde & adónde = what, which, who, how, how, how much, when, where & where)
2. Adjust the Spanish translation (for the time being) to not use the diacritical marks.

@mivalencia

The fact that the answer cannot be read back is a feature.

We found a few glitches:

• a space at the end of a line that starts with print causes an error
• two variables on a print command works, but not if you put a non-variable (string) in between.

Needs a fix in the grammar, will then also fix the Spanish letters properly if we allow everything except for the quotation mark.

A line name is Vesper breaks.
A line name is Vesper runs fine.

This is a more generic version of the first bullet of print command glitches: #37

Currently app.py configures the application to be served on port 5000. I would like to suggest to use port 4339. This spells hedy on a phones number keys.

Correct answer is 10, not whatever the user answered :)

This will make Hedy more accessible for visually impaired people.

There is the possibility to create an account, yet it is not clear why one should do so (I guess to retain progress? Otherwise, that might be stored in cookies or so, too)

The explanation should be added at least to the  signup template for account creation

n is ask 'Hoe vaak?'

Does not compile.
But

print Hoe vaak?

also does not compile.

I'd prefer for the first to work, but know little of programming didacticts ;-) so up to you!
Consistency would be nice.

At the moment the text "Probeer dit" is hardcoded and cannot be translated:
https://github.com/Felienne/hedy/blob/245edc93f9c19ff74f9a441633a87be1123cdf94/templates/index.html#L18-L19

See:

Not sure if we should enrich the lang or give a better error message?

Tailwind CSS is now ~1 MB (!!). Follow these instructions and maybe add a minifier to get the filesize to a reasonable size:

https://v0.tailwindcss.com/docs/controlling-file-size

For example: http://www.hedycode.com/hedy/23?lang=nl

repeat does not take a variable as parameter?

n is ask Hoe vaak?
repeat n times print 'Zo vaak!'

UI/UX issues that you may not be able to solve, but good to know of:

1. Occassionally, after programs with errors were fixed, commands were executed twice. Do not know how to reproduce yet.
2. In Explorer / Edge, backspace is "back"; I ended up switching the kid to Firefox (they should do that anyways) because pressing backspace when Hedy does not have the focus caused him to loose his work time and time again, unrecoverable with "Forward" because state is not kept.
3. However, a child on a different (Linux) laptop and browser (FF) did seem to recover state.

Better to remove that when not logged in, found this to be confusing for kids.

8d7f424 adds new exception handling to prepare for that.

This is more of a UX problem.
On my screen, the error message appears below the code box, and thus sometimes not visible if there are to many 'Try this' boxes above. So that I didn't figure something was wrong directly without visual feedback.
To reproduce, type garbage in lesson2 in english then hit 'run code'

A user should be able to:

• Log in (optionally with existing provider like Google or GitHub)
• Log out
• See a list of their projects at each level
• Make projects public or private
• Reset their password
• Change their avatar

Sometimes the error messages reads: print is geen commando, bedoelde je print?

That is terrible we should catch this and replace by a more generic error.

Hi,

without the www. prefix there's some default page from the hosting provider. Maybe redirect?

I saw that url in the fsharpConf presentation just a few minutes ago.

Thank you, have a nice day! ❤️

There is random text in a blockquote in NL level 1
I've looked around and I couldn't find the problem 1-2-3.

This is the first assignment for new users. The user journey can end prematurely.

Hedy Level 1 NL

We now email on subscribe and manually add to the mailinglist, that does not scale. There must be an API we can use instead?

At the moment the index.html has almost no indentation. It would make me happy without bounds if we could properly indent the structure.

Error messages should be hidden or at least simplified. (maybe this should be a broader issue, linked to #12 ?)
Empty lines are not valid syntax and throws :

The server couldn't translate this Hedy program to Python.
Unexpected end-of-input. Expected one of: * LETTER * __ANON_1 * __ANON_1 * __ANON_1 * DIGIT * __ANON_1 * __ANON_1 * __ANON_1

I would like to have used or and maybe also having in would be good (one kid had a program that tested if the input is in a range she put in a list).

Variable punten is not defined.

Could be an exercise for the pupil to find it, but maybe too difficult at the start of the level :-)