Giter Club home page Giter Club logo

Comments (5)

fpereiro avatar fpereiro commented on August 24, 2024

@Felienne indeed, we should change the message. Unfortunately this type of dialog only allows for one type of redirect, not two.

What we can do is to redirect to /login, which has quite visible the "No account yet? Create account" link. Would this be good enough or should we build a custom pop-up with options for /login and /signup, as well as cancel?

from hedy.

Felienne avatar Felienne commented on August 24, 2024

I would propose we redirect to login, if they login with a non-existing username or email, redirect again to register (potentially with the email/username they filled out already there?)

from hedy.

fpereiro avatar fpereiro commented on August 24, 2024

We could redirect to login and if the credentials are wrong and there is no matching username, suggest in the red box that they might want to create an account. Security-wise it's not great, since it allows for a quick way to figure out if someone's username or email is already being used. It's not too different from what could be achieved by doing the same on the signup form, but it is easier.

Here's my proposal: if there are invalid credentials submitted on login, we add a button to suggest to create a new account, whether there is an account with that email/username or not. If they click on it, their email (or username) is populated already on the form. Would that work?

from hedy.

Felienne avatar Felienne commented on August 24, 2024

Here's my proposal: if there are invalid credentials submitted on login, we add a button to suggest to create a new account, whether there is an account with that email/username or not. If they click on it, their email (or username) is populated already on the form. Would that work?

I think that sounds reasonable, but I do want to see it in action with kids

from hedy.

fpereiro avatar fpereiro commented on August 24, 2024

Agreed. I'll go ahead with it then and we'll see what happens in action!

from hedy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.