hartenthaler / hh_relation_is_descriptor Goto Github PK

I was able to modify hh_relation_is_descriptor to my v.2.1.2. I want to extend the dropdown list for name types. It is used to extend NameType.php. I am not sure if this is how I should contact you. Please let me know if there is a more appropriate way to ask for help. At least is does not crash or get a fatal error. I just cannot make the NAME:TYPE dropdown list to show my extended version
hh_ChinAmNameType.zip
.

First of all, thanks for the effort in creating this module!

I tested it with webtrees 2.0.19.

1. I added three relations (twin, triplet, minister) in RelationIsDescriptorAddon.php, and their translations in ExtendedRelationIsDescriptor.php.
2. Then I removed these relations from app/Elements/RelationIsDescriptor.php (where I had previously added them) and I disabled my translation module.

At that point, these relationships are not translated.

The translations do work when I add these relations back to app/Elements/RelationIsDescriptor.php. Therefore, it seems that ExtendedRelationIsDescriptor.php is not working.

Also, the relation type minister is not available in the associates drop-down menu because it's missing in app/GedcomCode/GedcomCodeRela.php:

I'm still working on the way to use and translate relation descriptors depending on the sex of the person.

there is no save button

You have to edit raw GEDCOM instead.

To define a class that extends the existing class RelationIsDescriptor, I tried the following but this is not correct.

class RelationIsDescriptorAddon extends AbstractModule implements RelationIsDescriptor, ModuleCustomInterface

Error message:
Hartenthaler\Webtrees\Module\RelationIsDescriptorAddon\RelationIsDescriptorAddon cannot implement Fisharebest\Webtrees\Elements\RelationIsDescriptor - it is not an interface

class RelationIsDescriptorAddon extends RelationIsDescriptor implements AbstractModule, ModuleCustomInterface
or
class RelationIsDescriptorAddon extends RelationIsDescriptor implements ElementInterface, ModuleCustomInterface
or
class RelationIsDescriptorAddon extends RelationIsDescriptor implements ModuleCustomInterface
are not working, too.

How should the class definition look like?

Translation of relation descriptors is context-sensitive (depending on the sex). But I don't know how to do this using the PHP I18N function.