Giter Club home page Giter Club logo

Comments (8)

ric2016 avatar ric2016 commented on July 3, 2024

I linked to the 2.1 version of the ElementFactory in the forum thread, which only has one entry for RelationIsDescriptor. The current 2.0 version has three others (in 'Gedcom-L extensions'), which likely also have to be overwritten, see this file.

Regarding the use of GedcomCodeRela.php: That's not good. Maybe this is handled better in 2.1, in 2.0 there is no clean way to override this file. The easiest solution is probably to swap it out altogether. Vesta does this for a few files as a last resort, see e.g. the code starting here.

from hh_relation_is_descriptor.

hartenthaler avatar hartenthaler commented on July 3, 2024

My development environment is already based on webtrees 2.1. Then I checked it very short with 2.0.19 and did not see an error, but the test was too short. Now I added support for FAM::_ASSO:RELA, INDI::ASSO:RELA, and FAM:*:_ASSO:RELA.

from hh_relation_is_descriptor.

hartenthaler avatar hartenthaler commented on July 3, 2024

As far as I can see, the module is working under webtrees 2.1.

I do not plan to solve the problem with GedcomCodeRela.php in webtrees 2.0. As far as I have tested it, the module should show (and translate) custom relation descriptors in webtrees 2.0.19 with the next release. But you will not see the custom values in the selection menu, i.e. you have to edit raw GEDCOM if you like to add new custom relations to a person, a family, or an event.

from hh_relation_is_descriptor.

hartenthaler avatar hartenthaler commented on July 3, 2024

In the latest version of webtrees 2.1 the function "register" was removed. I used this function to register new relation descriptors. Now I'm lost. The core of my module is in RelationIsDescriptorAddon.php in line 197ff in function boot(). I do not have any idea how to register new relation descriptors.

from hh_relation_is_descriptor.

ric2016 avatar ric2016 commented on July 3, 2024

In the latest version of webtrees 2.1 the function "register" was removed

It has been renamed to 'registerTags'.

from hh_relation_is_descriptor.

hartenthaler avatar hartenthaler commented on July 3, 2024

@ric2016 thanks a lot! so easy! Now it is working.

@TheDutchJewel it would be nice if you can test this release now together with webtrees 2.1

from hh_relation_is_descriptor.

TheDutchJewel avatar TheDutchJewel commented on July 3, 2024

@hartenthaler your module works fine!

I tested version 2.1.1.0 with webtrees 2.1.1.

  1. First I checked what happened when I removed three relations (minister, twin and triplet) from app/Elements/RelationIsDescriptor.php (where I had previously added them): now the relations were not shown in the associates drop-down menu, as expected.

  2. Then I added the relations in h_relation_is_descriptor\ExtendedRelationIsDescriptor.php, and tried again: now the relations were shown in the associates drop-down menu, which is OK.

The translation also works fine by adding these terms to the translation module (which is an modified version of the example module), or by adding them at the end of the file hh_relation_is_descriptor\RelationIsDescriptorAddon.php.

from hh_relation_is_descriptor.

hartenthaler avatar hartenthaler commented on July 3, 2024

@TheDutchJewel Thanks for testing!

from hh_relation_is_descriptor.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.