PyHSPlasma: Crashes when loading and unloading converted Minkata files about libhsplasma HOT 6 CLOSED

I did a bisect, with the following result:

1219763c443b91b7b18be79335a24894312c54ef is the first bad commit
commit 1219763c443b91b7b18be79335a24894312c54ef
Author: Bartek Bok <[email protected]>
Date:   Thu Jul 26 21:48:25 2012 +0200

    Load callbacks

from libhsplasma.

The problem is as follows: Scene objects add callbacks to themselves to all their modifiers. However, when the modifier is removed from the scene object or the scene object is deleted, the callbacks stay - and later, they are called even though the scene object has already been deleted. The call is happening in plKeyData::setObj.

I wrote a temporary patch to fix the problem so that I can continue using my scripts, you can find it at diafero@1d890aa. It's probably not a proper fix though...

from libhsplasma.

The key leaks are the immediate issue here, and those have been fixed by 5c93fdd... However, the other half of this is that the std::bind parameter references an object which can potentially be deleted before the callback is called. I feel it's slightly less important, but it should be fixed at some point (e.g. by assigning owners to callbacks).

from libhsplasma.

The key leaks are the immediate issue here, and those have been fixed
by 5c93fdd... However, the other half of this is that the
std::bind parameter references an object which can potentially be
deleted before the callback is called. I feel it's slightly less
important, but it should be fixed at some point (e.g. by assigning
owners to callbacks).

Well, I tend to disagree (crashes seem more serious to me than memory
leaks), but my immediately problem is fixed ;-)

from libhsplasma.

Well, this fixes both the crash and the memory leak for your case... What I meant was that the case where the code fails (crashes) is now significantly less likely to occur than it was before (you'd actually have to try to do it) -- and we may have fixed other unseen bugs as well in the process.

from libhsplasma.

This bug is no longer present.

from libhsplasma.