Comments (5)
Hoikas
commented on July 28, 2024
This looks like libHSPlasma's better bit vector compression... IIRC
from libhsplasma.
diafero
commented on July 28, 2024
The result of the bisect is rather surprising...
125954fb65a6652c5b7bdb83cb2625aa97e723c4 is the first bad commit
commit 125954fb65a6652c5b7bdb83cb2625aa97e723c4
Author: diafero <[email protected]>
Date: Mon Mar 19 15:17:01 2012 +0100
prp-checkfiles: do not stop comparing objects after the first difference
:040000 040000 a76f536bc3286c8dc3ecfae4e3e393e3a722a623 941d6797e5625c2b745b0ed90c1f69c4c030c4ba M Python
WTF? That really shouldn't change things...
I'm still investigating, but don't have any more time today.
from libhsplasma.
diafero
commented on July 28, 2024
Okay, I think I'm just too stupid to read. Prior to that commit, my script only had a single complaint, and I simply missed that one. You are probably right with your bit vector compression. Of course, this means that checking whether anything got actually lost, is much harder.
from libhsplasma.
zrax
commented on July 28, 2024
It would probably be easier to do a semantic comparison with something like PRC than with the binary objects themselves. There are cases (hsBitVector being the most common) where the data may not be stored identically even though they are semantically equivalent.
from libhsplasma.
diafero
commented on July 28, 2024
The problem with that is that it won't catch errors in the read code -
it may read the data as being the same, even though for the game, they
actually are not the same.
from libhsplasma.
Related Issues (20)
- SceneObject modifier list race conditions HOT 2
- PyHSPlasma should accept `os.PathLike`
- Visual C++2013 build broken. HOT 3
- Python CMakeLists incorrectly determines PYTHON_LIB_DIR
- PyHSPlasma Type Stubs
- Fails to build on Debian testing
- -nan(ind) is converted to a number HOT 2
- Lighting Regression HOT 1
- Vertex colors are zeroed in Cluster groups
- Shared Mesh issue HOT 3
- drawable span permalights wont save correctly
- Files not saving correctly with Use Win32 API commit
- MQO prps fail to open correctly HOT 15
- CMake visibility changes break PyHSPlasma on Python < 3.9
- Particle Pitch and Yaw zero out when modified
- SSE compile flags unconditionally added HOT 1
- More Object ID complaints: PRC round-tripping
- instant crash when editing large drawable span
- Port to string_theory regressed opening some prp files HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libhsplasma.