grmmph / ghostscroll Goto Github PK

I've noticed that single quotes are not being escaped and are creating attribute closures thereby creating broken click events for fnav. I see that the links themselves are based on the title of the article. Maybe adding an identifier tag to each post and linking to those could be a possible solution.

Thanks for the beautiful theme! My issue can be reproduced like this:

• Scroll a bit down, so that the menu appears
• Reduce size window, so that small-device rules kick in
• Then you can see the menu, tiny on top...
• Scroll up, then the menu disappears and will never reappear.

I'm not sure if I've just not installed/configured this correctly, but I am not able to get the buttons to work. Also, the posts don't appear to alternate by color. Is there anything else I need to do?

I downloaded the newest FA release, made sure the reference in default.hbs was still correct and pushed it to my site, but it doesn't update, what am I missing?

Thanks!

ghostscroll v0.1.1 on android phone oneplus5

Nav menu showing when in landscape mode but disappears in portrait.
If menu is showing in landscape it will remain when rotating to portrait, scroll to the top to see it disappear (expected behaviour?) and then back down and it will not come back.

Lots of love for this project!

Hi @grmmph it seems this project has been abandoned for quite some years. Let it be known that a there is https://github.com/zjedi/hugo-scroll , that was originally inspired by this theme (as per the founder, I took it over a year ago).

Let me know if I misinterpreted anything, I didn't mean to to steal your users, merely redirect them to a more lively code alternative.

Why are you using Jquery to apply the blue background and white text to every odd post via inline styles?

why not use CSS :nth-of-kind(2)?

Is this for compatibility with older browsers? I suppose it must be. How about applying an alt class instead?

im happy to refactor and submit a pull request. I just want to understand the reasons for why it was done in the first place.

P.S. using this for my personal site, and would have built it if it did not exist.

When I select GhostScroll theme my page just goes to flat text. There are no buttons and no scrolling.

When the resolution is too high, the last item in the list isn't selected when I scroll to the bottom of the page or when I click it.

index.js line71:

h = $sitehead.offset().top + $(this).height()-100;

should be changed to

h = $sitehead.offset().top + $sitehead.height()-100;

Ghost shows the ordered lists in both editor and preview:

But the final output is unordered asterisks:

Where is the next page button?

Please load the external resources from Google using "//" instead of http. This way people hosting on HTTPS don't have mixed content.

This isn't a bug. But I miss a share button. Can someone add that?

Navigation never appears in portrait on iOS, tested in Safari & Chrome.

It does appear if rotate to landscape mode. Tested using GhostScroll page itself.

Please update to support the newest features and conventions of Ghost.

Please upgrade GhostScroll and add new {navigation} option!

http://dev.ghost.org/ghost-0-5-9/

Thanks
LP

License.txt has the MIT license, but the top of the default.hbs Creative Commons SA-NC-BY is listed.

Perhaps I'm misunderstanding the point of Featured Post, but with a theme like GhostScroll, I would want it to force featured posts to the top of the list. If I find a work around I'll let you know.

There is no list item (LI) icon applied to OL or UL list items. The only place I see the icon-asterisk style is in the ie7 css files:

./assets/js/index.js: $('li').before('<span class="bult icon-asterisk"></span>') ./assets/font-awesome/scss/font-awesome-ie7.scss:.icon-asterisk { ./assets/font-awesome/less/font-awesome-ie7.less:.icon-asterisk { ./assets/font-awesome/css/font-awesome-ie7.css:.icon-asterisk { ./assets/font-awesome/css/font-awesome-ie7.min.css:.icon-asterisk{*zoom:expression( this.runtimeStyle['zoom'] = '1', this.innerHTML = '&#xf069;');}

Did you intend to show the * icon for any LI's in your theme? Is so the font-awesome.min.css that is included in index.hbs does not have the icon-asterisk style in it.

I've attached some images. I set list-style to decimal in screen.css just to test.

Default

added "decimal" to list-style in screen.css

** markup

The background colour alternates from grey to blue for posts, but it also does this for table rows which results in tables looking like this when they have multiple rows:

Hi there when i make the browser smaller in width to test the reposnive layout
there is a large sideways movement and a horizontal scroll bar appears at the bottom
is this a vieport meta tag issue?

plsea let me know

thanks

bo

The demo link to http://ghostscroll.grmmph.com/ does not work.

Just thought I'd drop in and post a link to theme developer guide to what changed in Ghost 0.4.

I'm trying to encourage as many theme devs as possible to upgrade to use the {{asset}} helper in particular. Without this change, your theme won't work when Ghost is installed in a subdirectory, and users may encounter caching problems.

Thanks 👍

If you browse to a Post via Direct link the Share This Post buttons at the bottom are not displayed. Just the words Share This Post.

In the live demo/documentation it says that you can use markdown to call the icons. I tried to use the quoted code in a post, but it did not show up. Could you speak to this? Am I doing it wrong? :)

Thanks