gookit / color Goto Github PK

System:

• OS: linux
• GO Version: 1.16
• Pkg Version: 1.4.0

TERM=xterm

Describe the bug

After upgrading to 1.4.0, no more color in output, without error.

To Reproduce

Upgrade to v1.4.0.

green := color.FgGreen.Render
fmt.Println(">>> Blah :", green("blahblah"))

Expected behavior

The color must be printed as expected.

Using hex colors I can't use two different colors on the same line (Windows 10)

Hi. I ran the demo.go to test and it did not work.
I am on ubuntu linux 19.04.
Thanks.

Cannot display color in tmux, Can you fix it?

this is a example, not in real time on the Command Line

System (please complete the following information):

• OS: Windows 10
• GO Version: 1.1.5
• Pkg Version: Latest

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Use my module and run go test -v .

Expected behavior

A clear and concise description of what you expected to happen.

Same output as Windows Terminal

Screenshots

What I get:

Additional context

The screenshot is from VsCode but the same problem doesn't happen in Git Bash.

Hey!

You should use terminfo instead of relying on the terminal name in TERM. This can provide you the number of colors supported. Otherwise, you are missing a lot of terminals supporting colors, like rxvt or screen. In Go, it seems https://github.com/xo/terminfo can do that. It also seems to handle some edge cases for terminals not using the correct TERM. It also handles the special case of true color which was not available through terminfo until recently and is able to fallback to COLORTERM (but it should be using Tc if available).

IsSupportTrueColor
(bool) true
IsSupport256Color
(bool) false
IsSupportColor
(bool) false

env | grep TERM
COLORTERM=truecolor
TERM=alacritty

github.com/gookit/color v1.2.7

System (please complete the following information):

• GO Version: 1.16.6
• Pkg Version: 1.4.2

Describe the bug

color.Basic2hex returns an empty string on background colors

To Reproduce

fmt.Printf("'%s'\n", color.Basic2hex(uint8(color.BgRed)))
// > ''
fmt.Printf("'%s'\n", color.Basic2hex(uint8(color.FgRed)))
// > 'c51e14'

Expected behavior

I expect the same response on a background color like so:

fmt.Printf("'%s'\n", color.Basic2hex(uint8(color.BgRed)))
// > 'c51e14'
fmt.Printf("'%s'\n", color.Basic2hex(uint8(color.FgRed)))
// > 'c51e14'

I am using your library in box-cli-maker and use color.ClearCode to clear colors from the string but it doesn't work on Mac OS's iterm terminal though works on other OSes Terminal.

Read this issue for the detailed information Delta456/box-cli-maker#29

System (please complete the following information):

• OS: linux
• GO Version: 1.18.1
• Pkg Version: 1.5.2

ENV info on the terminal (by command env | grep -i TERM):

COLORTERM=truecolor
TERM_PROGRAM_VERSION=3.2a
TERM=tmux-256color
TERM_PROGRAM=tmux

Describe the bug

I am using tag-style color rendeing to colorize tabular data. If multiple lines contain something like this: <none> then only the first colorziation works, subsequent ones are not replaced but printed as is.

To Reproduce

package main

import (
	"github.com/gookit/color"
)

func main() {
	test1 := `FAILS:
one <bg=lightGreen;fg=black>two</> <three>
foo <bg=lightGreen;fg=black>two</> <four>

`

	test2 := `WORKS:
one <bg=lightGreen;fg=black>two <three></>
foo <bg=lightGreen;fg=black>two <four></>

`

	test3 := `WORKS:
one <bg=lightGreen;fg=black>two</> three
foo <bg=lightGreen;fg=black>two</> four
`

	color.Print(test1)
	color.Print(test2)
	color.Print(test3)
}

Expected behavior

The colorziation should work independently from other non color-tag content.

Screenshots

See screenshot attached.

** Edited to add **

The problem occurs ONLY if the "tagged" content appears outside the colorization. If it's inside, it works. Sample code and screenshot updated.

Running this with multiple go routines causes this crash (on windows):

runtime: bad pointer in frame github.com/gookit/color.EnableVirtualTerminalProcessing at 0xc000581838: 0x58
fatal error: invalid pointer found on stack

runtime stack:
runtime.throw(0xc6d2fe, 0x1e)
        C:/Program Files/go/src/runtime/panic.go:1116 +0x79 fp=0xb2f1bff4d0 sp=0xb2f1bff4a0 pc=0x659799
runtime.adjustpointers(0xc000581838, 0xb2f1bff5c0, 0xb2f1bff948, 0xfbcc00, 0x100e2a0)
        C:/Program Files/go/src/runtime/stack.go:605 +0x1e8 fp=0xb2f1bff520 sp=0xb2f1bff4d0 pc=0x66e888
runtime.adjustframe(0xb2f1bff858, 0xb2f1bff948, 0x100e2a0)
        C:/Program Files/go/src/runtime/stack.go:647 +0x36b fp=0xb2f1bff5f0 sp=0xb2f1bff520 pc=0x66ec0b
runtime.gentraceback(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0xc000084d80, 0x0, 0x0, 0x7fffffff, 0xc89118, 0xb2f1bff948, 0x0, ...)
        C:/Program Files/go/src/runtime/traceback.go:334 +0x11b5 fp=0xb2f1bff8c0 sp=0xb2f1bff5f0 pc=0x67acd5
runtime.copystack(0xc000084d80, 0x2000)
        C:/Program Files/go/src/runtime/stack.go:910 +0x2a7 fp=0xb2f1bffa78 sp=0xb2f1bff8c0 pc=0x66f387
runtime.shrinkstack(0xc000084d80)
        C:/Program Files/go/src/runtime/stack.go:1178 +0x149 fp=0xb2f1bffaa0 sp=0xb2f1bffa78 pc=0x670429
runtime.scanstack(0xc000084d80, 0xc00002de98)
        C:/Program Files/go/src/runtime/mgcmark.go:815 +0x56e fp=0xb2f1bffca8 sp=0xb2f1bffaa0 pc=0x640e4e
runtime.markroot.func1()
        C:/Program Files/go/src/runtime/mgcmark.go:245 +0xce fp=0xb2f1bffcf8 sp=0xb2f1bffca8 pc=0x681cee
runtime.markroot(0xc00002de98, 0x14)
        C:/Program Files/go/src/runtime/mgcmark.go:218 +0x310 fp=0xb2f1bffd80 sp=0xb2f1bffcf8 pc=0x63f910
runtime.gcDrain(0xc00002de98, 0x7)
        C:/Program Files/go/src/runtime/mgcmark.go:1109 +0x138 fp=0xb2f1bffdd8 sp=0xb2f1bffd80 pc=0x641578
runtime.gcBgMarkWorker.func2()
        C:/Program Files/go/src/runtime/mgc.go:1981 +0x176 fp=0xb2f1bffe18 sp=0xb2f1bffdd8 pc=0x681bd6
runtime.systemstack(0x0)
        C:/Program Files/go/src/runtime/asm_amd64.s:370 +0x6b fp=0xb2f1bffe20 sp=0xb2f1bffe18 pc=0x68a6ab
runtime.mstart()
        C:/Program Files/go/src/runtime/proc.go:1116 fp=0xb2f1bffe28 sp=0xb2f1bffe20 pc=0x65e920

fmt.Println will add spaces if called like:
fmt.Println("hello", "world") -> "hello world"

If I do:
color.Println("<comment>hello</>", "world")

expected result: "hello world"

actual result: "helloworld"

There are some extra color code problems in different shells.
The Light Red and Light Blue has problem in Windows shell.
Extra background has problem in Linux shell.

有些高亮的色碼有問題
在windows中亮紅 亮藍 反了
在linux中 高亮背景 亂了

Hi! I think it will be good to also add methods to take hsl as input and convert it by different variants.

For reference, you can refer to this code.

I need this feature as I will be adding HSL format as input option for my box-cli-maker.

Alpine does not support printing colors?

I'm using the HTML like tags feature to pretty print some JSON, but I'm concerned that occasionally the JSON data might have tags like that would start getting rendered as a color. I did a search and replace and didn't see anything, so was wondering if there was a way to escape or encode tags to make it so that color tags aren't injected?

As we have a function to round off true color to 256 colors, can we allow have a method to round off true color to 16 colors?

IDEA 2020.1 on Windows 10

I'd like to print raw HTML colored, and I don't want gookit/color to interpret the HTML in the string. Is there a way to ignore the HTML?

This tool looks really promising! So thanks in advance.

I'm running into some issues with your isSupportColor method on Windows, which affects RenderCode.

1. Pure git-bash:
   • $MSYSTEM = MINGW64
   • $TERM = xterm
   • 256 coloration seems to work
2. ConsoleZ git-bash (started via C:\Program Files\Git\bin\sh.exe --login -i)
   • $MSYSTEM = MINGW64
   • $TERM = cygwin
   • coloration is disabled
   • 16-color coloration is possible via github.com/fatih/color - Output
3. CMD:
   • %CMDEXTVERSION% = 2
   • coloration is disabled
   • 16-color coloration is possible via github.com/fatih/color - Output
4. Powershell:
   • Version: 5.1.16299.1146
   • coloration is disabled
   • 16-color coloration is possible via github.com/fatih/color - Output

My method for testing includes creating a color.C256 object and using it's Sprint method to output the string to write to a github.com/fatih/color - Output Writer.

Thanks!

When I running go get github.com/gookit/color ., I found

go/src/github.com/gookit/color/tag.go:117:3: undefined: EnableCmdColorRender
go/src/github.com/gookit/color/tag.go:130:3: undefined: EnableCmdColorRender
go/src/github.com/gookit/color/tag.go:143:3: undefined: EnableCmdColorRender

Here the output from the demo, I was expecting your nice colors: unfortunately it's all white.

What do you think the problem is ? Did you encounter such problem ?

• NeoFetch output if needed:

OS: Manjaro Linux x86_64 
Kernel: 4.19.81-1-MANJARO
Shell: bash 5.0.11 
Resolution: 1920x1080 
WM: i3 
Theme: Adwaita [GTK3] 
Icons: Adwaita [GTK3] 
Terminal: urxvt 
Terminal Font: DejaVu Sans Mono

Thank you for your time,

Hi, you'd better change color.Green.Print("Simple to use color") to color.Green.Print("Simple to use color\n")

Hi, i tried your example it print message only in default gray color.

func IsConsole(out io.Writer) bool {
	o, ok := out.(*os.File)
	if !ok {
		return false
	}

	return o == os.Stdout || o == os.Stderr || o == os.Stdin
}

func TestOther(t *testing.T) {
	is := assert.New(t)

	is.True(IsConsole(os.Stdout))
	is.False(IsConsole(&bytes.Buffer{}))

Sometimes the standard input / output / error streams are redirected to files. In such cases, IsConsole will still return true, but the writer is not a console or terminal

System (please complete the following information):

• OS: Kubuntu 22.04.2 LTS x86_64
• GO Version: 1.20.4
• Pkg Version: v1.5.4

ENV info on the terminal (by command env | grep -i TERM)
TERM_PROGRAM_VERSION=1.80.0
COLORTERM=truecolor
TERM=xterm-256color
TERM_PROGRAM=vscode

Describe the bug

When Printf recieves a "colored" string as argument it does not colors the part of string after %s.

To Reproduce

package main

import (
	"github.com/gookit/color"
)

func main() {
	color.FgRed.Printf("first %s third\n", color.FgYellow.Render("second"));
}

Expected behavior

I would expect that "first" and "third" will be colored in red, second in yellow. Instead first is colored in red, second in yellow and third in white

Screenshots
VS Code integrated terminal:

Konsole:

Additional context
I also tried this on Konsole and i have encountered the same issue.

With the recent commit, not all returns return a value in tryEnableVTP()

System (please complete the following information):

• OS: Ubuntu 20.04 and Debian 10.8
• GO Version: 1.16.2
• Pkg Version: latest

Describe the bug

When I used screen to start my go program, the color would loss. But fmt would not.

To Reproduce

// color code
import (
        "fmt"
        "time"
        "github.com/gookit/color"
)

func main() {
        // 简单快速的使用，跟 fmt.Print* 类似
        color.Red.Println("Simple to use color")
        color.Green.Print("Simple to use color\n")
        color.Cyan.Printf("Simple to use %s\n", "color")
        color.Yellow.Printf("Simple to use %s\n", "color")

        // use like func
        red := color.FgRed.Render
        green := color.FgGreen.Render
        fmt.Printf("%s line %s library\n", red("Command"), green("color"))
        color.Green.Println(time.Now().Format("[2006-01-02 15:04:05]  "), "Test")

        // 自定义颜色
        color.New(color.FgWhite, color.BgBlack).Println("custom color style")

        // 也可以:
        color.Style{color.FgCyan, color.OpBold}.Println("custom color style")
        
        // internal style:
        color.Info.Println("message")
        color.Warn.Println("message")
        color.Error.Println("message")
        
        // 使用颜色标签
        color.Print("<suc>he</><comment>llo</>, <cyan>wel</><red>come</>\n")

        // apply a style tag
        color.Tag("info").Println("info style text")

        // prompt message
        color.Info.Prompt("prompt style message")
        color.Warn.Prompt("prompt style message")

        // tips message
        color.Info.Tips("tips style message")
        color.Warn.Tips("tips style message")
        time.Sleep(time.Minute)
}

// fmt code
package main
  
import (
        "fmt"
        "time"
)

func main() {
        fmt.Printf("\x1b[%dmhello world 30: 黑 \x1b[0m\n", 30)
        fmt.Printf("\x1b[%dmhello world 31: 红 \x1b[0m\n", 31)
        fmt.Printf("\x1b[%dmhello world 32: 绿 \x1b[0m\n", 32)
        fmt.Printf("\x1b[%dmhello world 33: 黄 \x1b[0m\n", 33)
        fmt.Printf("\x1b[%dmhello world 34: 蓝 \x1b[0m\n", 34)
        fmt.Printf("\x1b[%dmhello world 35: 紫 \x1b[0m\n", 35)
        fmt.Printf("\x1b[%dmhello world 36: 深绿 \x1b[0m\n", 36)
        fmt.Printf("\x1b[%dmhello world 37: 白色 \x1b[0m\n", 37)
        time.Sleep(time.Minute)
}

Expected behavior

When I use screen to start my program, the color will not turn to white

Screenshots

System (please complete the following information):

• OS: macOS
• GO Version: 14.3.1
• Pkg Version: 1.5.4

ENV info on the terminal (by command env | grep -i TERM)

TERM=xterm-256color
TERMINAL_EMULATOR=JetBrains-JediTerm
TERM_SESSION_ID=xxx

Describe the bug

When using this library for printing messages, the program runs noticeably slower than when using just fmt.Print.

To Reproduce

entries := map[string]string{
	"test": "fest",
	"rest": "best",
}

i := 1

yellow := color.FgGreen.Render

for k := range entries {
	_, err := fmt.Println(yellow(strconv.Itoa(i)+". ", k))

	if err != nil {
		color.Errorln(err)
	}

	i++
}

Expected behavior

To run at similar speed compared to using the fmt package.

system：windows7
use: cmd.exe
It runs normally on Win10 system, but No color output on Windows 7

I really like this cyan and want to use it somewhere else. But I couldn't find it after searching the source

Using the .Render method of Styles like color.New(color.OpItalic, color.OpBold), color.New(color.Cyan), or color.New(color.BgGray) doesn't seem to work on Windows. The full code I wrote is here, please test it for yourself and let me know if I made a mistake. Is it because I'm using tabwriter? The colors work fine on Linux.

On Windows, if there are many goroutines that try to write on the console (by using the Fprint function, for example), there is good chance the output will be scrambled, like so.

Removing the lines 184-187 on the file color_windows.go seems to fix this issue.

Not sure why the color setting needs to be reverted, is that needed?

PowerShell 7.0.0-rc.2