tag-style color rendering fails if lines contain tag like content about color HOT 5 OPEN

#53 fixes the issue for me.

from color.

hi @TLINDEN

FAILS:
one <bg=lightGreen;fg=black>two</> <three>
foo <bg=lightGreen;fg=black>two</> <four>

On fails, will match: <bg=lightGreen;fg=black>two</> <three>\nfoo <bg=lightGreen;fg=black>two</> ... Maybe is right, because color support match like <info> contents </>

If change regex s to m, will be not match mulit line contents:

foo <bg=lightGreen;fg=black>
two
</>

from color.

But then, there's still an issue, since <three> is no valid color tag. However - even if it were, the color module shall throw an error because there's no matching </> closing tag for it. And it's also too greedy, from my understanding as a user, it should be:

1. match an opening tag, either <$name> or <bg|fg...>
2. match the smallest possible part til the next part
3. match the closing tag </>

Or, if we translate the example into HTML:

one <b>two</b> &lt;three&gt;
foo <b>two</b> &lt;four&gt;

You'll get:
one two <three>
foo two <four>

But not:
one two <three>
foo two <four>

Now, I see that the s flag needs to be there in order to be able to match color tags spanning multiple lines. And since GO doesn't support negative lookahead lookups (which would fix it!), how can both cases be satisfied?

from color.

Ok, while I still think that this behavior is somewhat buggy, I resolved my issue by using regexp.ReplaceAllStringFunc() and inside I am using the color.Style.Sprint() function directly. That way I don't have to cope with any disambiguities.

So, from my point of view the case could be closed. Thanks for the fast response!

from color.

Thanks you
I didn't think of a good way :)

Maybe ... can direct limit all color tag name. eg: info|red|yellow....

But then, there's still an issue, since <three> is no valid color tag. However - even if it were, the color module shall throw an error because there's no matching </> closing tag for it. And it's also too greedy, from my understanding as a user, it should be:

1. match an opening tag, either <$name> or <bg|fg...>
2. match the smallest possible part til the next part
3. match the closing tag </>

Or, if we translate the example into HTML:

one <b>two</b> &lt;three&gt;
foo <b>two</b> &lt;four&gt;

You'll get: one two foo two

But not: one two foo two

Now, I see that the s flag needs to be there in order to be able to match color tags spanning multiple lines. And since GO doesn't support negative lookahead lookups (which would fix it!), how can both cases be satisfied?

from color.