1.106.0 conflict with WPML about site-kit-wp HOT 8 CLOSED

Nice work! Thank you all.

from site-kit-wp.

@aaemnnosttv Here was @eugene-manuilov's suggestion on a fix via Slack:

What we can do on our side:
Remove the current approach of finding the base path for products
Implement the new approach that will query one random product from the database and use it to detect the product base path
Found path will be cached for X minutes (probably something between 1-5 mins) to avoid querying the database for every request.

from site-kit-wp.

Just FYI, the exact issue occurred on my web server with PHP 8.1.21

from site-kit-wp.

Thanks, @robertstaddon! As you can see, we're working to address this on our side, but WPML has also notified us that they're planning to release a fix in their own update next week. You can follow along with them here: https://wpml.org/errata/site-kit-by-google-uncaught-typeerror-illegal-offset-type-in-isset-or-empty-in/.

from site-kit-wp.

Hi, I am Pierre from WPML and indeed we've included one more check on our side to prevent this kind of error. This will go out with WPML 4.6.5 scheduled for next Monday.

That said, I strongly support the idea of a better (less random) approach to discover the product URL format. As suggested by @eugene-manuilov, trying to fetch an existing product from the DB would probably be a more robust solution.

from site-kit-wp.

Thanks @strategio, that's great to hear 👍 We'll use this issue to fix the problem people are experiencing now and we'll iterate on our implementation to be more robust in another as this is part of a future feature that isn't available yet.

Our next release is scheduled for the following Monday the 14th.

from site-kit-wp.

IB ✔️

from site-kit-wp.

QA Update: ✅

Verified:

• I was able to recreate the issue on PHP 8.2 and unable to setup Site Kit or access the dashboard with WPML, WooCommerce and Site Kit 1.106.0 installed and setup.
• When I switched to the develop branch the issues no longer exist. I was able to setup Site Kit and also access the dashboard. I tested this with the Userinput feature flag enabled and disabled. There are some PHP errors on 8.2 but not linked to this issue. We have reported these here. I also ran through on PHP 7.4 just for peace of mind.

from site-kit-wp.