Comments (8)
Nice work! Thank you all.
from site-kit-wp.
@aaemnnosttv Here was @eugene-manuilov's suggestion on a fix via Slack:
What we can do on our side:
Remove the current approach of finding the base path for products
Implement the new approach that will query one random product from the database and use it to detect the product base path
Found path will be cached for X minutes (probably something between 1-5 mins) to avoid querying the database for every request.
from site-kit-wp.
Just FYI, the exact issue occurred on my web server with PHP 8.1.21
from site-kit-wp.
Thanks, @robertstaddon! As you can see, we're working to address this on our side, but WPML has also notified us that they're planning to release a fix in their own update next week. You can follow along with them here: https://wpml.org/errata/site-kit-by-google-uncaught-typeerror-illegal-offset-type-in-isset-or-empty-in/.
from site-kit-wp.
Hi, I am Pierre from WPML and indeed we've included one more check on our side to prevent this kind of error. This will go out with WPML 4.6.5 scheduled for next Monday.
That said, I strongly support the idea of a better (less random) approach to discover the product URL format. As suggested by @eugene-manuilov, trying to fetch an existing product from the DB would probably be a more robust solution.
from site-kit-wp.
Thanks @strategio, that's great to hear 👍 We'll use this issue to fix the problem people are experiencing now and we'll iterate on our implementation to be more robust in another as this is part of a future feature that isn't available yet.
Our next release is scheduled for the following Monday the 14th.
from site-kit-wp.
IB ✔️
from site-kit-wp.
QA Update: ✅
Verified:
- I was able to recreate the issue on PHP 8.2 and unable to setup Site Kit or access the dashboard with WPML, WooCommerce and Site Kit 1.106.0 installed and setup.
- When I switched to the develop branch the issues no longer exist. I was able to setup Site Kit and also access the dashboard. I tested this with the
Userinput
feature flag enabled and disabled. There are some PHP errors on 8.2 but not linked to this issue. We have reported these here. I also ran through on PHP 7.4 just for peace of mind.
from site-kit-wp.
Related Issues (20)
- Add the “New” badges to the Selection Panel
- Add the Introductory Popup / Banner (Storybook)
- Show the Introductory Popup / Banner to view-only users and secondary admins
- Ensure view-only users and secondary admin settings follow the default settings
- Ensure CTAs don’t appear for view-only users
- Ensure the “Top content” metric doesn’t appear for view-only users if the custom dimension doesn’t exist
- Add REST and datastore APIs for audience settings HOT 5
- Add the Settings Section toggle switch variant and hook up the setting to toggle the Audiences Widget Area on/off HOT 1
- Add the Settings Section setup CTA variant including happy path setup behavior
- Implement the Settings Section unhappy setup path
- Handle changing the connected Analytics property
- Add Site Health section
- Analytics data inconsistent for Arabic language pages in Site Kit
- AdSense module place code even if Set up is not complete.
- Implement the “no audiences” banner error state HOT 1
- Update the design of the PageSpeed Insights widget's "gathering data" state
- Include snippet detection within a users Site Health report - Specifically the "Info" tab
- Release 1.120.0
- [GTM + GA4] Remove functionality preventing GA4 from outputting tags when GTM takes over HOT 1
- Add `adsModule` Feature Flag HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.