Giter Club home page Giter Club logo

Comments (5)

techanvil avatar techanvil commented on August 17, 2024 1

Hi @hussain-t, just a heads up that I've tweaked the requirement for this issue to include removing the link to the settings section in the selection panel for view-only users.

from site-kit-wp.

benbowler avatar benbowler commented on August 17, 2024 1

Thanks @kuasha420, updated!

from site-kit-wp.

hussain-t avatar hussain-t commented on August 17, 2024 1

We don’t have an easy way to view the Audience Segmentation widgets until #8130 is implemented. Therefore, I’ve updated the dependency. This task should be worked on once #8130 is completed.

cc: @techanvil @ivonac4

from site-kit-wp.

kuasha420 avatar kuasha420 commented on August 17, 2024

Thank you @benbowler for working on this IB. A couple of points.

  1. Looks like AudienceSegmentationSetupCTAWidget is not being rendered on shared dashboard anyways as it's guarded in assets/js/components/DashboardMainApp.js.
  2. We also should follow similar pattern for AddGroupNotice, by preventing it from rendering in shared dashboard in assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel/index.js.

Thanks.

from site-kit-wp.

kuasha420 avatar kuasha420 commented on August 17, 2024

IB ✔️

from site-kit-wp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.