Comments (4)
Hey @benbowler, while reviewing the IB here I've realised I left an important detail out of the AC.
The "New" badges should only appear for audiences which have been created subsequent to the initial setup for the current user.
The implication is we should expire the corresponding "New" badge items for the list of audiences in configuredAudiences
once they have been successfully saved in the enableAudienceGroup()
action
It further implies we should do the same thing once configuredAudiences
has been saved as part of the setup for a secondary user. This is being specced in #8130, as a result I've added that issue as a dependency for this one.
Apologies for the lack of clarity in the AC. I've amended it accordingly - please take a look.
Further to the above, here are a couple of additional points for this IB:
- The following point can be removed, as we do want to display a "New" badge for these audiences if a user has created them via the CTA in the Selection Panel. Also, please note as a general point, and as per my comment on #8160, we don't want to be identifying these audiences via a string comparison of their
displayName
as the display name is mutable.
- Also, prevent the badge from being rendered if the the title is either of the pre-defined audiences "All visitors" or "Returning visitors" using simple string comparison.
- A trivial one, but I'd consider a slight simplification of the expirable item ID. Rather than
audience-selector-new-audience-expirable-new-badge-${slug}
which contains "new" twice, the repetition of which feels somewhat redundant, how aboutaudience-selection-panel-expirable-new-badge-${slug}
?
from site-kit-wp.
Looks like this is also blocked by a tile like #8136 being implemented, because adding a relatively concrete IB here isn't possible until those components are implemented so we know where they'll go. I looked through all of the issues to see if anything was moved along enough to add a good IB here but not yet, so I've added #8136 as another blocker to making the IB 🤔
from site-kit-wp.
Thanks @benbowler. The IB LGTM ✅
Please note, I made a small tweak to remove the reference to enableAudienceGroup()
for the secondary users aspect, as I don't think we will end up using this action for secondary users, rather we'll extract part of it to a new action and use that.
from site-kit-wp.
Note that I've further updated the IB in response to the observations made here, #9096 (comment), as the generic Selection Panel should indeed not know anything about audiences.
from site-kit-wp.
Related Issues (20)
- Creation of `Top cities driving purchases` ACR KMW
- Creation of `Top cities driving purchases` ACR KMW
- Creation of `Top device driving purchases` ACR KMW
- Creation of `Top device driving purchases` ACR KMW
- Creation of `Top traffic source driving purchases` ACR KMW
- Glitches / errors when changing the audience selection in mobile viewports
- Impossible to stop tagmanager code placement HOT 1
- Agency with hundreds of client Google Analytics accounts unable to assign correct profiles HOT 2
- Remove `conversionInfra` feature flag
- Remove localization for module homepage URLs
- Improve the `resetPublications` action HOT 6
- Requests made for module settings on dashboard
- Implement Internal Measurement/Tracking Following ACR KMW Updates
- Enhance compatibility with Docker locally for E2E
- Refactor the `ZeroDataNotification` to use the new lighter `Notification` component. HOT 2
- Release 1.134.0
- Add "Edit in Reader Revenue Manager" link for the RRM module
- Sort Storybook menu items HOT 1
- Enhance feature activation for BC
- Revert the Fix For VRT failures
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.