Comments (6)
I'm not planning on sending a PR. I just wanted to track this issue. I'm most concerned with https://github.com/lit/lit/pull/2103/files#diff-9204efca403aca3ce114a362b26ecd70d56cc7f3e093f895c9cfc2bd2b4f4800 which allows lit to be used via importmap on a CDN.
from model-viewer.
Planning to send a PR? Would also be nice to know what this unblocks, though I agree that staying up-to-date with dependencies is a good idea.
from model-viewer.
Does that issue flow down to MV? I believe MV works via importmap on a CDN currently.
from model-viewer.
I might be a bit confused about this matter. On this page https://modelviewer.dev/examples/postprocessing/ I see an importmap is used for three
, but not for lit
. My assumption was that lit
needs to be in the importmap as well since it is a dependency in https://github.com/google/model-viewer/blob/master/packages/model-viewer/package.json#L86C6-L86C9
from model-viewer.
No, we generally bundle all of our dependencies so that no import maps are needed. For the special case of the optional postprocessing feature, we split it into three: model-viewer-module, model-viewer-effects, and the standard three.js library which they both depend on. Lit is still bundled (it's tiny).
from model-viewer.
Oh, cool! Thanks for explaining it to me.
from model-viewer.
Related Issues (20)
- Module not found: Error: Can't resolve './styles/evaluators', and many more HOT 5
- Unable to get canvas of the invisible model if there are multiple models on the page and there are less than two models visible HOT 4
- use of "auto" in /editor/ output creates wrong orbit distance
- Is is possible to launch AR mode automatically?
- Missing propagation of the progress event reason
- Frames Rendering to Incorrect Canvas - Multiple Model-Viewers on Page HOT 6
- Ar button problem HOT 1
- How to access the hierarchy and then Three.js changes each object. HOT 1
- When I use scene viewer the model is placed sideways. HOT 1
- Setup lantern demo : bulb light should be visible outside of lantern box
- Generated usdz has a random y rotation when the auto-rotate attribute is used HOT 2
- Generated USDZ files don't work anymore on VisionOS 1.2 beta HOT 5
- AutoUSDZ broken in iOS 17.5 beta HOT 18
- xr-environment attribute causes errors the second time a webxr session is started HOT 6
- WebXR mode does not time out when it fails HOT 4
- iOS REGRESSION: Apple Pay banner fails to render when opening AR QuickLook with USDZ blob
- modelviewer ar-placement= wall is flipping the glb model HOT 10
- Object requires a newer version of iOS HOT 13
- safari artifact issue HOT 2
- Microsoft Edge app browser does not launch AR Quick Look on iOS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from model-viewer.