Comments (18)
Weird, I was just replying to their bug and in the middle of it they removed my permission to access the bug??
from model-viewer.
I can still see the ticket. And the latest comment is:
After some discussion we reached a solution where the end user behavior for opening the USDZ blob will be identical to opening the USDZ files from https://developer.apple.com/augmented-reality/quick-look/
Hopefully this is a reasonable compromise solution
That's still a bit ambiguous though. So have asked for clarification.
But could be good. 🤞
from model-viewer.
Dang, @AdaRoseCannon I hope Apple appreciates all the gratis effort here to help fix their product!
from model-viewer.
Good news! This is now fixed in iOS 17.5 beta 4.
Auto USDZ is once again working in ModelViewer.
All of my tests from https://arquicklook-usdz-blob.glitch.me/ now pass for all model types and all methods of opening the generated USDZ.
Thank you @AdaRoseCannon for helping escalate.
from model-viewer.
Excellent work all, helping Apple to get this fixed! @AdaRoseCannon does Apple have any kind of public bug tracker where we can alert you to these issues and be notified when they're resolved? Or should model-viewer continue providing that service for you?
from model-viewer.
I made some more test cases and found some interesting observations. I stripped things back to a bare bones implementation. I removed ModelViewer from the equation and am using three.js USDZ Exporter directly.
See here:
https://arquicklook-usdz-blob.glitch.me/
Step 1. Pick a model. Some are GLB, simple and complex. Some are ThreeJS primitives.
Step 2. View chosen model in ThreeJS.
Step 3. USDZ blob is automatically generated (from three.js) and attached to USDZ anchor link on the page. Time taken to generate blob and the blob size is displayed underneath. Tapping this USDZ link works - all test models open in ARQL.
Step 4. Update USDZ. This generates a new USDZ blob and attaches to the USDZ link. USDZ link still works - all models open in ARQL.
Step 5. Simulate a click event on the USDZ link. Works fine for all models.
Step 6. Generates a new blob, attaches to the USDZ Link, then simulates a click event. Some models work and open to ARQL. Some models fail.
Step 7. Generates a new blob, dynamically creates an anchor tag, attaches the blob, simulates a click (replicating ModelViewer's approach). Some models work and open to ARQL. Some models fail.
Step 8. View it in an iFrame and repeat all the steps above. For Steps 6 and 7, for models that fail, the prompt only shows an option to Download, not View.
Observations:
-
Is the simulated click an issue? Simulated click in Step 5 works fine and simulated clicks still work for SOME models in Step 6 and 7. So a simulated click isn't necessarily the issue.
-
Is the asynchronous nature of model generation and simulated click an issue? Is it too long a gap between user interaction and simulated click? However, the Astronaut model takes 100ms to generate, and FAILS to open in ARQL. But the Teapot model takes longer - 170ms - and DOES open in ARQL. So time does not set to be the cause.
-
Is blob size an issue? However, Astronaut blob is around 1,300 KB and FAILS. But Teapot blob is 11,000 KB and DOES work. So blob size does not seem to be the cause.
-
All the models that DO work, have NO textures. All the models that DON’T work, DO have image based texture maps. For example, Chrome model has no textures and works. Rustic Iron model, which uses the exact same geometry, has texture maps, and FAILS to open in ARQL.
Conclusions:
- All models pass steps 3, 4, 5.
- Some GLB models fail steps 6 and 7.
- Some GLB models pass steps 6 and 7.
- All ThreeJS primitives pass all steps.
- All GLB models with no textures pass all steps.
- All GLB models with textures fail steps 6 and 7.
So it seems to be a combined factor of models with textures, generating USDZ blob, and simulating a click.
Maybe...?
from model-viewer.
I think #4742 is related to this.
from model-viewer.
In iOS 17.5, simulated click events will trigger the download path which is why you see the new behavior.
We will ask three.js if they can open the blob directly from the user action, which would avoid the download path behavior.
That's fine, but it's still their bug. Activating WebXR on Chrome has exactly this same requirement - it's a good one. However, Chrome is smart enough to track that the simulated click originated from a user action. Safari needs to do the same.
from model-viewer.
Just thinking some more...
Simulated clicks are still working fine in ModelViewer in iOS 17.5 when using a USDZ source file.
It's only an issue when there's a USDZ blob.
So it does seem more of a blob-handling bug rather than intentionally blocking simulated clicks, maybe.
from model-viewer.
Also replied there. I didn’t have access rights at first but did after logging in again.
The new behavior is super strange, for example the USDZ renderer in the browser is a different one than in AR (some models don’t even display in the Browser one). Plus it breaks in many different ways on visionOS…, and iFrames don't work at all.
from model-viewer.
Also, as @hybridherbst points out, this totally breaks when opening from an iFrame. The prompt only displays the option to Download. There's no option to View. That's going to break a lot of embedded 3D viewers.
See:
https://modelviewer-extended-params.glitch.me/parent.html
from model-viewer.
FYI @AdaRoseCannon
from model-viewer.
Thank you for bringing it to my attention please report it via Feedback Assistant so it gets tracked. Also if you like please send me the code so I can track it.
from model-viewer.
Thank you for bringing it to my attention please report it via Feedback Assistant so it gets tracked. Also if you like please send me the code so I can track it.
Thanks @AdaRoseCannon - now reported via Feedback Assistant with some additional information and test cases (FB13734957)
from model-viewer.
That's great! Thank you :)
from model-viewer.
@AdaRoseCannon I had also reported this already as FB13722319 with a number of different cases that all break in slightly different ways, hope that helps
from model-viewer.
Thank you @hybridherbst
from model-viewer.
Still an issue with iOS 17.5 beta 3
from model-viewer.
Related Issues (20)
- Is is possible to launch AR mode automatically?
- Missing propagation of the progress event reason
- Frames Rendering to Incorrect Canvas - Multiple Model-Viewers on Page HOT 6
- Ar button problem HOT 1
- How to access the hierarchy and then Three.js changes each object. HOT 1
- When I use scene viewer the model is placed sideways. HOT 1
- Setup lantern demo : bulb light should be visible outside of lantern box
- Generated usdz has a random y rotation when the auto-rotate attribute is used HOT 2
- Generated USDZ files don't work anymore on VisionOS 1.2 beta HOT 5
- xr-environment attribute causes errors the second time a webxr session is started HOT 6
- WebXR mode does not time out when it fails HOT 4
- iOS REGRESSION: Apple Pay banner fails to render when opening AR QuickLook with USDZ blob
- modelviewer ar-placement= wall is flipping the glb model HOT 10
- Object requires a newer version of iOS HOT 13
- safari artifact issue HOT 2
- Microsoft Edge app browser does not launch AR Quick Look on iOS
- addon boilerplate?
- Invisible occlusion mesh !
- Upgrade to latest version of threejs (r164.1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from model-viewer.