Giter Club home page Giter Club logo

Comments (4)

lawnjelly avatar lawnjelly commented on June 25, 2024 6

Ah this could be a regression from MergeGroups. I don't think it looks serious, just a check for CPU source mesh which doesn't make sense with the old method.

I should be able to fix this up soon.

from godot.

lawnjelly avatar lawnjelly commented on June 25, 2024 2

I've done a PR to fix this, essentially the problem was just the new method defaults to creating meshes on CPU only and the MeshInstance::merge_meshes() should create GPU meshes for use in the editor and rendering.

There is one additional change to be aware of here since 3.5:

  • Mesh merging is now visibility aware, so if hidden meshes are merged, they will be merged to a hidden result.
  • This means that in your script you either need to hide the source meshes after merging, or unhide the result mesh after merging.

Also as the merging backend has changed it may be more stringent for requirements for merging (it checks hopefully absolutely everything, so if e.g. a margin is different, then it will not merge).

I'm hoping to add a verbose mode for merging that will print out reasons for not merging (as this could be annoying to work out manually) but this may have to wait till a point release as we are in feature freeze.

from godot.

SkanerSoft avatar SkanerSoft commented on June 25, 2024 1

Thank you very much! If you need testing it, let me know, I will help!

from godot.

lawnjelly avatar lawnjelly commented on June 25, 2024 1

Thank you very much! If you need testing it, let me know, I will help!

Hopefully a lot of the jobs you previously did with MeshInstance::merge_meshes() can now be automated better with MergeGroup, as it essentially does what you were doing in your script, either at runtime or baked in the editor.

Any testing you can give would be greatly appreciated! 😀

https://docs.godotengine.org/en/3.6/tutorials/3d/merge_groups.html

from godot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.