Comments (5)
@Bromeon see godotengine/godot#68479 ;-)
from gdext.
Thanks for the heads-up! 👍
No worries, change detection of the GDExtension header has already been automated, outputting a descriptive diff 😉
Nevertheless it's even nicer to have a descriptive changeset, so I appreciate being proactive! I also wrote a comment regarding godotengine/godot#61968, which might now be mitigated or even fully solved.
I might then use this issue to track the progress of implementing those changes.
from gdext.
No worries, change detection of the GDExtension header has already been automated, outputting a descriptive diff wink
That's pretty sweet !
which might now be mitigated or even fully solved
I think the issue is fully solved, however it would be even better to entirely remove the get_property_list
an replace it by an array passed where get_property_list
function pointer is currently provided.
This would simplify the API and remove the ambiguity that get_property_list
might get called multiple time and can return different result each time it is called (to support dynamically adding property, which is of course not a thing in Godot)
What do you think ?
from gdext.
however it would be even better to entirely remove the
get_property_list
an replace it by an array passed whereget_property_list
function pointer is currently provided.
You mean when the class is registered, one would provide an array of all properties?
I think that might be ideal, because then the extension library can forget (aka deallocate) the property meta-information once registered. I might need to check the implementation to make sure I'm not missing something though 🙂
from gdext.
I think that might be ideal
I will try to find time to submit a PR to Godot then, and I'll ping you for the review then 😃
I might need to check the implementation to make sure I'm not missing something though
Please do ! My guess is the GDExtension API use this "function to pass constant values" pattern only because it leaks it C++ implementation where generics are implemented with templates and function argument specialization 😄
from gdext.
Related Issues (20)
- Recent commit causes "GDExtension initialization function 'gdext_rust_init' returned an error" HOT 1
- Vector3 signed_angle_to is incorrect
- Simple VideoStreamPlayback causes thread panic HOT 4
- It is possible to have a `Base` pointing to a dead object HOT 2
- Issues with string & sse4 support HOT 3
- Problems related to multithreaded access imposed by Godot
- It is tricky to figure out how to properly use `WithBaseField` generically
- commit() failing for SurfaceTool in simple case HOT 6
- godot endlessly prompting to restart HOT 5
- Foreign Classes / Interfaces HOT 1
- Converting Typed Arrays to Variant Arrays Panics HOT 12
- Can't export variable with suffix HOT 3
- You can use the wrong `ITrait`
- Is it possible to call rust function from a new thread in Godot 4.2? HOT 2
- Failed to load class method XXX HOT 3
- Consistent by-value and by-ref parameters for geometric types HOT 3
- Incorrect mapping of object pointers in native structs HOT 3
- Gd<XXX>.bind() cause crash, with `api-custom` feature in custom build godot. HOT 12
- Low-hanging consistency fruits
- Gd<T: GodotClass> derived from Resource upcasted mut to &mut T contains only default values HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gdext.