Giter Club home page Giter Club logo

Comments (2)

Bromeon avatar Bromeon commented on August 23, 2024

This sounds very similar to #23 -- which is about subtyping but should also cover dead objects.

I'll need to look into it a bit deeper 🤔

from gdext.

Bromeon avatar Bromeon commented on August 23, 2024

It's also possible to do this without thread-locals:

#[derive(GodotClass)]
#[class(init)]
struct Foo {}

impl Foo {
    fn smuggle_out(other_base: &mut Option<Base<RefCounted>>) -> Gd<Self> {
        Gd::from_init_fn(|base| {
            *other_base = Some(base);
            Self {}
        })
    }
}

#[derive(GodotClass)]
#[class(base = Node, init)]
struct Bar {}

#[godot_api]
impl INode for Bar {
    fn ready(&mut self) {
        let mut option = None;
        let foo = Foo::smuggle_out(&mut option);
        let extracted_base = option.unwrap();
    }
}

And of course, you can swap two objects' base field after construction, similarly to #23.


I don't think it's possible to protect fully against this (at least not without major ergonomic impediments), so we should probably double-check that we don't rely on bases being always valid, or pointing to the original object.

from gdext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.