Bug Report

Current behavior

As reported by a user:

In the GitHub Pages course, It has you update your user ID in the config. It then uses that to create a link to your GitHub profile on the bottom of the blog post page. I think that link should point to your GHE instance instead of GitHub.com if you’re running the course from GHES.

The minima theme automatically generates the link to point to github.com in: https://github.com/jekyll/minima/blob/aeab39123d8b5f853bc2427c0d72318a2b5055bd/_includes/social.html#L8

Possible solution

We could look at the other packaged themes: https://pages.github.com/themes/ to see if switching would fix the problem.

/cc @amyschoen @brianamarie @hectorsector

Context: This project card and this discussion.

Blog posts aren't visible in the chosen Jekyll theme. This is a learning outcome of the course, and a learner has asked about it on the forum.

Feature Request

Describe the problem/friction you are trying to solve
Currently, GitHub Pages does not load content properly when said content is hosted by Git LFS. (for example, https://radzo73.github.io/fparchive/FPAW1.html loads its Flash .swf just fine because the .swf isn't hosted on Git LFS, but https://radzo73.github.io/fparchive/FPAW3.html doesn't load its Flash .swf properly because its .swf is hosted with Git LFS)

Describe your ideal solution.
Git LFS support, so files on my GitHub Page load properly (for example, again, https://radzo73.github.io/fparchive/FPAW3.html would load its Flash .swf properly if Git LFS support was added.)

Drawbacks: None?

Describe alternatives you have considered.
Adding/using alternatives to Git LFS (nothing that I know of)

A post in the community forum mentions that the instructions for step 5 are incorrect.

@hectorsector Can you please help figure out if this is true? If not, how have they come to this conclusion?

Bug Report

Current behavior
Homepage titles are redundantly printed twice. The course description also shows a screen capture where the page title Welcome to my blog is printed twice.

Reproduction
Steps to reproduce the behavior in the course:

1. Follow the course steps up to Step 4: Customize Site Details, keeping index.md beginning with a heading. For example, the default file begins with # Welcome to my blog.
2. Click the link to the published page, represented as [here]({{ deploymentUrl }}):

   github-pages/responses/03_change-theme.md

   Lines 1 to 3 in 6db77ad

   	## Step 4: Customize Site Details
   	Great work! You can see your published page [here]({{ deploymentUrl }}). If you don't see your changes right away, refresh the page.

3. See the beginning heading, e.g. Welcome to my blog, replicating itself twice.

Expected behavior
It is enough to print it just once like this:

Possible solution
Replace the default beginning heading # Welcome to my blog in index.md with a front matter like this:

-# Welcome to my blog
+---
+title: “Welcome to my blog”
+---

I’m glad you are here. I plan to talk about …

Or just delete the number sign (#) of the beginning heading to make sure that index.md do not begin with a heading.

Additionally, add an instruction like “Write your homepage title in a front matter.” or a warning like “Make sure that index.md do not begin with a heading without a page title front matter.” to responses/01_update-index.md where users update index.md.

Additional context
I found the same issue and solution here and here.

I also made a post on Github Community Forum.

Bug Report

Current behavior
The course doesn't detect compilation errors in jekyll.

Reproduction
Steps to reproduce the behavior in the course:

Step 4: Customize Site Details

1. Start the value for github_username in _config.yaml with an @.
2. Finish the rest of the instructions and eventually merge in the PR.
3. You receive an email notification that looks like this:

The page build failed for the `master` branch with the following error:
You have an error on line 9 of your `_config.yml` file. For more information, see https://help.github.com/enterprise/2.19/user/en/articles/troubleshooting-jekyll-build-errors-for-github-pages-sites#config-file-error.
For information on troubleshooting Jekyll see:
  https://help.github.com/enterprise/2.19/user/articles/troubleshooting-jekyll-builds
If you have any questions you can contact us by replying to this email.

4. The course still congratulates you on successful completion.

Expected behavior
I would expect that an issue with the config file would not lead to successful course completion.

Possible solution
Find some way of detecting that pages didn't get deployed correctly and have them go back and edit.

Additional context
N/A

/cc @crichID @brianamarie @hectorsector @JasonEtco

Bugs

• Lab step 2 has a typo in hompage
  • Image
• Step 2 does not link to the next pull request
• Step 2 does not automatically close after successful completion
  • Image
• Step 3 does not respond after successful completion.
• Lab does not update following step 2.
  • Image
  • Image
• General thoughts - I think this course could use polish updates similar to the Communicating with Markdown course
  • PRs automatically opened with specific files ready for edit

cc: @JasonEtco

Bug Report

Current behavior
Post not showing up.

Reproduction
Steps to reproduce the behavior in the course:

1. Go to this issue: carolynshin/github-pages-with-jekyll#4, which tells me that I successfully completed the course.
2. Go to my page: https://carolynshin.github.io/github-pages-with-jekyll/
3. See error: No post

Expected behavior
I expected my post to show up on my page but I do not see it.

Possible solution
N/A

Additional context
Another user on the learning lab community forum experienced this problem. It is most likely because there are issues with their post - they didn't add a space between the date and the date value, and it looks like they added their blog content inside the frontmatter. I was testing out this course to see if it fixed the user's issue and couldn't get my post to work either.

/cc: @hectorsector and @a-a-ron

When attempting to get past the Customize your homepage step, I see the following error on my terminal:

  Error in customize-your-homepage:gate[2] TypeError: Cannot read property 'findIndex' of undefined
      at Object.includes (/Users/hec/github/learning-lab/lib/actions/gate/index.js:32:14)
      at evaluate (/Users/hec/github/learning-lab/lib/actions/gate/index.js:43:32)
      at opts.gates.some.gate (/Users/hec/github/learning-lab/lib/actions/gate/index.js:54:14)
      at Array.some (<anonymous>)
      at Object.module.exports [as gate] (/Users/hec/github/learning-lab/lib/actions/gate/index.js:52:26)
      at Context.module.exports (/Users/hec/github/learning-lab/lib/utils/run-action.js:26:23)
      at module.exports (/Users/hec/github/learning-lab/lib/utils/run-actions.js:6:37)
      at <anonymous>
      at process._tickDomainCallback (internal/process/next_tick.js:228:7)

It also appears the step isn't being marked complete in the dash, although the PR is approved.

This seems to be related to this portion of the config:

Bugs

• Step 2 links to a broken website
  • Image
• Step 4 does not prompt the user with next steps after successful completion (lab updates correctly and new issue is generated)
  • Image
• Step 5/6 does not leave a review on the open PR.
  • Image

cc: @JasonEtco