Allow manually specifying application id, version name and code about sentry-fastlane-plugin HOT 7 OPEN

Hey @lwasyl,
thanks for explaining why you need this feature. If the sentry-cli supports the UUID for the proguard upload I don't see any reason why we shouldn't support it at well via fastlane. I can't give you an ETA though for this. Please upvote if anybody else wants this feature too.

from sentry-fastlane-plugin.

We are also happy to accept PRs if you are motivated @lwasyl ;)

from sentry-fastlane-plugin.

@lwasyl Do you use Sentry Android Gradle Plugin? If not, why?

from sentry-fastlane-plugin.

@bruno-garcia I am but it's not working as expected supposedly due to getsentry/sentry-android-gradle-plugin#37. All I know is for now our release has no proguard mappings even though the plugin was applied correctly.

Other than that as a principle I'm trying to avoid Gradle plugins for things that can be easily done without it. I already spent some time understanding how Sentry matches Proguard mappings and the entire thing is needlessly convoluted for the simple use case: every release version has its unique mapping file. I opened getsentry/sentry-java#1333 and I'd have much higher confidence in having Proguard work with those simple pieces:

• attaching stable proguard mapping ID generated from application ID and version code, without generating any properties files as these values are easily retrieved in runtime
• uploading proguard mapping with the same ID during the release process, where we also know application ID and version code because we're just making a release so we need to know both

And I just realized that my request is wrong. I don't need to specify version code and version name, I need to specify proguard mapping ID (which sentry-cli also allows):

sentry_upload_proguard(
  auth_token: 'my_token', 
  org_slug: 'my_org',
  project_slug: 'my_project',
  app_id: 'com.my.app.id',
  mapping_uuid: 'com.my.app.id-130', # I'd set the same ID in the app
  mapping_path: 'build.proguard.txt',
)

from sentry-fastlane-plugin.

Hey @philipphofmann I wasn't motivated but someone was, unfortunately they PR was left ignored for a year and ultimately closed: #80

from sentry-fastlane-plugin.

Thanks for pointing that out, @lwasyl. I replied in the PR #80 (comment).

from sentry-fastlane-plugin.

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

from sentry-fastlane-plugin.