Setting include_sources:false should not upload SourceBundles about sentry-fastlane-plugin HOT 8 CLOSED

@nickkaczmarek Correct - you need to omit include_sources to prevent source bundles from being uploaded. no_sources is used to determine whether the server supports source bundles, but this is overridden by sentry-cli retrieving a list of supported formats from the server, so it has no effect here.

Thank you for the wording suggestion, I think this would make it much clearer. We will discuss in which direction we'll go and follow up here.

from sentry-fastlane-plugin.

@nickkaczmarek yes let's keep it open for now - we'll split out separate issue(s) later

from sentry-fastlane-plugin.

include_sources parameter is present - setting it to false currently doesn't deactivate this

I think if you set it to false, it should deactivate this. This would be a simple change.

from sentry-fastlane-plugin.

include_sources parameter is present - setting it to false currently doesn't deactivate this

I think if you set it to false, it should deactivate this. This would be a simple change.

This is what I thought would happen. I would guess I'm not alone in this. Also I think this makes more sense than updating the docs in the way I suggested above. False should not send the sources and true should send the sources.

from sentry-fastlane-plugin.

Hey @nickkaczmarek, thanks for writing in! Source bundles will be sent as soon as the include_sources parameter is present - setting it to false currently doesn't deactivate this, only removing the parameter. We'll discuss if we should change this behavior or at least document it more clearly.

from sentry-fastlane-plugin.

@kahest Ah okay that's good to know. So just to be clear, if I use sentry_upload_dif without include_sources or no_sources I should expect that no source bundles are uploaded?

from sentry-fastlane-plugin.

And to your point about documenting it more clearly

When setting the include_sources parameter to true, the Fastlane plugin will scan your debug files to find references to the source code files, resolve them in the local file system, bundle them up, and upload them to Sentry.

This line seems to imply that setting that property will cause a change in behavior.

Maybe something like:

When including the include_sources parameter, the Fastlane plugin will scan your debug files to find references to the source code files, resolve them in the local file system, bundle them up, and upload them to Sentry. Exclusion of this parameter will not upload source code files.

I can make an MR for the docs if you think this makes it clearer how this tool works.

from sentry-fastlane-plugin.

Thanks @kahest. Do you want me to keep this issue open? From my perspective I understand the behavior and my questions are answered, but not sure if you want to keep this open until a further docs/params change is made.

from sentry-fastlane-plugin.