Giter Club home page Giter Club logo

Comments (7)

marandaneto avatar marandaneto commented on September 27, 2024 2

We've agreed that downloading on the fly is actually an improvement since you don't bloat the repo and the user has to download only the needed binary, although, if it's working and it's not a source of complaints, we can prioritize more important issues, and this is eventually done when there are no more p1 for example.
cc @denrase @kahest @philipphofmann

from sentry-fastlane-plugin.

philipphofmann avatar philipphofmann commented on September 27, 2024 1

Maybe we could apply a similar approach as we do in getsentry/sentry-dart-plugin#49.

from sentry-fastlane-plugin.

bruno-garcia avatar bruno-garcia commented on September 27, 2024 1

The idea is to download when packaging. Downloading on the user's machine has the downside of slowing down the first build,. Requiring internet access on the build time as opposed to "restore deps" phase; and brings security concerns (unless we pin ssl cert, which isn't good to maintain).

So the trade off is to check in the Sha in the repo and in CI when packaging, download the binary and verify the checksum. The final artifact will bundle it.

from sentry-fastlane-plugin.

denrase avatar denrase commented on September 27, 2024

@bruno-garcia I could take over this issue if you don't have anyone else in mind already.

from sentry-fastlane-plugin.

philipphofmann avatar philipphofmann commented on September 27, 2024

Please take it @denrase.

from sentry-fastlane-plugin.

philipphofmann avatar philipphofmann commented on September 27, 2024

I agree with lowering the priority for this issue.

from sentry-fastlane-plugin.

github-actions avatar github-actions commented on September 27, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

from sentry-fastlane-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.