Comments (7)
We've agreed that downloading on the fly is actually an improvement since you don't bloat the repo and the user has to download only the needed binary, although, if it's working and it's not a source of complaints, we can prioritize more important issues, and this is eventually done when there are no more p1 for example.
cc @denrase @kahest @philipphofmann
from sentry-fastlane-plugin.
Maybe we could apply a similar approach as we do in getsentry/sentry-dart-plugin#49.
from sentry-fastlane-plugin.
The idea is to download when packaging. Downloading on the user's machine has the downside of slowing down the first build,. Requiring internet access on the build time as opposed to "restore deps" phase; and brings security concerns (unless we pin ssl cert, which isn't good to maintain).
So the trade off is to check in the Sha in the repo and in CI when packaging, download the binary and verify the checksum. The final artifact will bundle it.
from sentry-fastlane-plugin.
@bruno-garcia I could take over this issue if you don't have anyone else in mind already.
from sentry-fastlane-plugin.
Please take it @denrase.
from sentry-fastlane-plugin.
I agree with lowering the priority for this issue.
from sentry-fastlane-plugin.
This issue has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog
or Status: In Progress
, I will leave it alone ... forever!
"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀
from sentry-fastlane-plugin.
Related Issues (20)
- 1.12.2 error parsing sentry auth result HOT 3
- Will 1.13.0 be released soon (for bundled iOS sentry-cli)? HOT 8
- sentry-cli-Darwin-universal: 2: Syntax error: word unexpected (expecting ")") when running on circleCI Android image HOT 5
- upload_dif action cannot take list of paths HOT 3
- No such file or directory HOT 16
- Requesting to support `--ignore-missing` in sentry_set_commits
- It is unclear how dysm uploads are associated with releases in Sentry for iOS HOT 2
- Fix open source attributions HOT 2
- Replace `upload-dif`/`upload-dsym` to `debug-files upload` HOT 2
- Explicitly declare the token permissions in the readme HOT 1
- What scopes should auth_token have? HOT 2
- Build randomly fails with Error 413 Entity too large HOT 5
- Can't seem to upload `.symbols` (produced by `flutter build`) files to Sentry HOT 7
- Setting include_sources:false should not upload SourceBundles HOT 8
- "A required debug information file was missing" despite successful upload HOT 4
- Automate Sentry-cli bump HOT 3
- Option to control the log output HOT 7
- Action 'sentry_debug_files_upload' not available in 1.19 HOT 5
- Sentry Debug Files Upload Failure HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sentry-fastlane-plugin.