Introduce/enable a rule for trailing commas in rubocop about sentry-fastlane-plugin HOT 6 CLOSED

I'm not an expert on Ruby. Maybe it's worth checking out what we do here https://github.com/getsentry/sentry-ruby ?

from sentry-fastlane-plugin.

Sure that sounds reasonable. Are you up for a PR @denrase?

from sentry-fastlane-plugin.

Sure! Do you or anyone from your team have an opinion on this?

from sentry-fastlane-plugin.

@philipphofmann When trying to configure this, i wondered why rubocop is not issuing warnings when i made changes. Turns out, it is only configured for the Fastfile, as the AllCops include is overriding the default.

AllCops:
  Include:
    - '**/fastlane/Fastfile'

When removing the include, we get 232 offences, which may also include directories we don't care about.

Now the question is, is it supposed to be only configured for the Fastfile?

from sentry-fastlane-plugin.

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

from sentry-fastlane-plugin.

This was fixed with #121

from sentry-fastlane-plugin.