Giter Club home page Giter Club logo

Comments (4)

bruno-garcia avatar bruno-garcia commented on May 20, 2024

@HazAT wouldn't the root name property always be: sentry.dotnet?
IIRC we had a discussion where the goal was to simplify statistics so .NET SDK would be all under sentry.dotnet and the packages node will help us with what was installed in the app.
I believe we had this discussion with @mitsuhiko

Since I meet last week's discussion I might be missing updates though.

So proposing:

{
  "name": "sentry.dotnet",
  "version": "1.0.0-rc2",
  "packages": [
    {
      "name": "nuget:Sentry",
      "version": "1.0.0-rc2"
    },
  ]
}

for Sentry.AspNetCore it should look like this:

{
  "name": "sentry.dotnet",
  "version": "1.0.0-rc3",
  "packages": [
    {
      "name": "nuget:Sentry",
      "version": "1.0.0-rc"
    },
    {
      "name": "nuget:Sentry.Extensions.Logging",
      "version": "1.0.0-rc2"
    },
    {
      "name": "nuget:Sentry.AspNetCore",
      "version": "1.0.0-rc3"
    },
  ]
}

Root version prop would always be from the outer package.

from sentry-dotnet.

HazAT avatar HazAT commented on May 20, 2024

@bruno-garcia almost, it's like this getsentry/sentry-docs@02e4ff7

Since I think that Sentry.AspNetCore and Sentry.Extensions.Logging are both "SDKs" on their own (right?), they deserve to be a "flavor" like:

sentry.dotnet.aspnetcore
and
sentry.dotnet.extensions.logging

does this make sense?

That way we can boil it down to the individual SDK and still filter for everything dotnet related.
The packages can stay the way they are.

from sentry-dotnet.

HazAT avatar HazAT commented on May 20, 2024

The identifiers should basically match the folders here:
https://github.com/getsentry/sentry-release-registry/tree/master/sdks

from sentry-dotnet.

bruno-garcia avatar bruno-garcia commented on May 20, 2024

Closed by #105

from sentry-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.