Can't create BaggageHeader for SentrySdk.ContinueTrace(), it's not public about sentry-dotnet HOT 5 CLOSED

Thanks for the additional input! We're going to add an overload to the ContinueTrace that accepts the headers as strings.

from sentry-dotnet.

@bruno-garcia I haven't gotten around to testing it, but it sounds like it should be exactly what I needed. Thanks.

from sentry-dotnet.

Thanks for raising this. Fair point. That's an oversight but I'm not sure how to proceed here yet.

I'd like to avoid making the HttpContextExtensions methods public. I think we should rather provide overloads to the ContinueTrace to consume the headers more generically i.e. letting the SDK extract them from the System.Web.HttpContext and Microsoft.AspNetCore.Http.

from sentry-dotnet.

i.e. letting the SDK extract them from the System.Web.HttpContext and Microsoft.AspNetCore.Http.

I don't think that would help in my case, because I'm trying to set up tracing for a transport that isn't HTTP (in my case it's Service Fabric TCP transport). I took inspiration from https://github.com/getsentry/sentry-dotnet/blob/3.36.0/src/Sentry.AspNetCore/SentryTracingMiddleware.cs, and on the transmitting side I can use BaggageHeader.ToString(), but there's nothing available on the receiving side. For comparison, SentryTraceHeader.Parse is public.

from sentry-dotnet.

@j2ghz did this change resolve it for you? #2601

from sentry-dotnet.