Comments (3)
To give some context here:
Our ASP.NET HttpContextExtension
sets the transaction's NameSource
to URL
and does not extract the route.
from sentry-dotnet.
Additional Context
It's worth noting we might have some challenges with the default route (which is often the only route used by many applications) which is:
routes.MapRoute(
name: "Default",
url: "{controller}/{action}/{id}",
defaults: new { controller = "Home", action = "Index", id = "" },
constraints: new { id = "\\d+" }
);
Literally everything maps to "{controller}/{action}/{id}" as the routename when using this convention based routing configuration. We could assume that the controller name and action name are safe to share (i.e. not PII) and so pass those through but leave the id masked... which might give us more useful groupings if people are using the default route.
When people are not using the default route it's really hard to know which parts of the route are safe to store in the SentryEvents and which bits are potentially PII though... so we'd probably just have to leave everything masked in those cases (i.e. everything sharing the same route, where it's not the default route, would be grouped by Sentry on the server).
At least, that's one possible implementation.
from sentry-dotnet.
Relates to: getsentry/sentry-docs#7866
from sentry-dotnet.
Related Issues (20)
- Native iOS/Cocoa options naming - 4.0.0-beta.3 HOT 4
- Move LogCat prop to SentryOptions
- Set ip_address to {{auto}} by default, even if sendDefaultPII is disabled HOT 1
- Add In Foreground to App context HOT 4
- SDK Backpressure and 100% Sampling
- Log4Net integration should filter SDK logs
- MAUI MacCatalyst Apps have a `default.profraw` generated inside the .app bundle when the app exits HOT 17
- Spotlight support
- Failed to extract body. HOT 2
- The `Hub` should resolve the SentryClient in a consistent way
- Add Distributed Tracing to the ASP.NET Core Documentation HOT 1
- Ui Component Crash When Sentry is Initialized HOT 2
- Send frame `filename` including project root HOT 1
- Sentry ASP.NET Core configuration issue with Serilog HOT 2
- Device tests in CI should have diagnostic logging in output or attachment
- consolidate exception position in logger callbacks
- NoMobile sln including mobile targets HOT 6
- Replace SdkVersion from reflection to source generator
- No line numbers in local development HOT 2
- The `System.ObjectDisposed` exception is thrown when applying clipping to an element in MAUI HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sentry-dotnet.