Giter Club home page Giter Club logo

Comments (3)

bitsandfoxes avatar bitsandfoxes commented on June 12, 2024

To give some context here:
Our ASP.NET HttpContextExtension sets the transaction's NameSource to URL and does not extract the route.

from sentry-dotnet.

jamescrosswell avatar jamescrosswell commented on June 12, 2024

Additional Context

It's worth noting we might have some challenges with the default route (which is often the only route used by many applications) which is:

        routes.MapRoute(
            name: "Default",
            url: "{controller}/{action}/{id}",
            defaults: new { controller = "Home", action = "Index", id = "" },
            constraints: new { id = "\\d+" }
        );

Literally everything maps to "{controller}/{action}/{id}" as the routename when using this convention based routing configuration. We could assume that the controller name and action name are safe to share (i.e. not PII) and so pass those through but leave the id masked... which might give us more useful groupings if people are using the default route.

When people are not using the default route it's really hard to know which parts of the route are safe to store in the SentryEvents and which bits are potentially PII though... so we'd probably just have to leave everything masked in those cases (i.e. everything sharing the same route, where it's not the default route, would be grouped by Sentry on the server).

At least, that's one possible implementation.

from sentry-dotnet.

bruno-garcia avatar bruno-garcia commented on June 12, 2024

Relates to: getsentry/sentry-docs#7866

from sentry-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.