geofabrik / osmi_pubtrans3 Goto Github PK
View Code? Open in Web Editor NEWcode which powers the "new" Public Transport view of OSM Inspector
License: GNU General Public License v3.0
code which powers the "new" Public Transport view of OSM Inspector
License: GNU General Public License v3.0
If you route only has no way members which have an empty role (i.e. route with forward
, backward
or both
roles but valid stops and platforms), the error message reads like "route has only stops/platforms" but that is wrong. The error message should be rephrased.
While some of these are comprehensible, I have no idea what some of the others are:
error_over_non_rail
error_over_rail
error_unordered_gap
error_wrong_structure
no_stops_pltf_at_begin
stoppltf_after_route
non_way_empty_role
stop_not_on_way
no_way_members
unknown_role
unknown_route_type
stop_is_not_node
Road routes (relations with route=road
) are quite common in OSM. It would be nice if these can also be validated by OSM inspector. I think it is mainaly gabs in the order that needs to be searched for.
I think the best option is to add a new view for it (in the same dropdown where you now select for for example "routing" or "public transport").
I hope you can consider it because it would help validating those relations a lot.
I have two route relations, 4547782 and 4547783, among others relations that I have used osmi_inspector maintain validity. On 4/6/2021 I corrected a "stop not on way" error for both routes. It appeared that I mixed up two stops at a bus station via cloning of the routes. Thank you for this additional check. However, today, 4/7/2021, the routes are marked as invalid but no error text has been provided.
There is no information to tell me how to fix this invalid state. Is this a bug or are there some documentation items missing from the wiki page to tell me how to fix the reported issue with these relations?
layer: ptv2_routes_invalid
rel_id: 4547783
from:
to:
via:
ref: SR 51 OB
name: bus SR 51 Rapid OB
route: bus
operator: Valley Metro Org
error_over_non_rail: <===== Nothing listed.
error_over_rail:
error_unordered_gap:
error_wrong_structure:
no_stops_pltf_at_begin:
stoppltf_after_route:
non_way_empty_role:
stop_not_on_way:
no_way_members:
unknown_role:
unknown_route_type:
stop_is_not_node:
error_over_non_ferry:
Currently, routes using route=light_rail are flagged with the unknown_route_type
error in the "Public Transport - Routes" layer of OSM Inspector. Can support for light_rail be added?
the route "La Riviera" in this geofabrik link checks valid, while going against the oneway direction of several of its route segments.
e.g.: 1, 2.
In the "Public Transport - Routes" layer of OSM Inspector, bus routes that run along highway=bus_guideway
are flagged with the error_over_rail
error.
Is it possible to not flag bus routes that use bus_guideways?
There are multiple routes which are marked as invalid (Way members unordered or missing) all going through a junction which is correctly tagged as junction=circular.
See here
The relations (e.g. 388113 or 390963) seem fine in josm.
I would expect to handle it similar to junction=roundabout.
Relations 5323808 and 79525 in Hagen, Germany are considered as invalid because the bus does a u-turn immediately after the first way.
Add support to new tagging of BRTs: highway=busway https://wiki.openstreetmap.org/wiki/Tag:highway%3Dbusway, and thus avoid the error_over_rail.
title says it all, I'm using the view public transport - routes to highlight whenever a route in my area becomes broken. unfortunately this works properly only for urban buses, where no section is "hail_and_ride". for rural bus routes, they all fail the role test.
if I understand the logic, we have two types of way members, one set where the roles would identify the way as a platform, one set where the roles would identify the way as a route section. as of now, members of this second set are only allowed the empty role, while I need 'hail_and_ride' to be accepted as well.
in this example area one route now correctly passes all tests, two more routes should pass all tests (now failing the unknown_role
test), one route should fail the no_stops_pltf_at_begin test
as it indeed does now.
Currently some routes (e.g. rel_id: 2806129) are marked as invalid because of the tag route=light_rail being an "unknown_route_type".
Would be nice to see them as valid routes.
Quite often, one or several stations drop out of a route. This can be quite easily detected for a backward+forward pair of routes in a route_master:
A -->-- B -->-- C -->-- D
A --<-- B --<-------<-- D
While this situation may often take place in reality, for subway routes this almost always signals about an error.
Since 2018, I have occasionally corrected such errors. Over the past two months, laborious work has been done to find them in nearly 300 subway and other rapid transit networks. As a result, about 150 stations were added to routes even in such well-mapped cities as Madrid, Stockholm, Warsaw, New York, Stuttgart, Munich S-Bahn, etc. There were about 10% false positives, mostly on routes of train
type.
This became possible after adding missing station search algorithm to the Subway validator. I suggest implementing the same check in your validator.
PTv2 spec specifies that one should tag stop_entry_only
or stop_exit_only
for first and last stops respectively. But OSMI does not recognize these roles in route relations .
OSMI gives the error No stop or platform as first member = true
if first stop role is stop_entry_only
or platform_entry_only
Example rel_id=11599082
Currently only valid/invalid can selected on the HMI.
It would be nice to have more categories (stop order, rail error, route gap, ..) to easily see only routes with the error(s).
Might be tricky as routes can have multiple of these errors.
More a nice to have feature-request as the information is available in the route details.
Now I see in my city error "error: | trolley bus without trolley wire"
http://tools.geofabrik.de/osmi/?view=pubtrans_routes&lon=24.22763&lat=56.98671&zoom=15&overlays=ptv2_error_,ptv2_error_ways,ptv2_error_nodes
It is true. But it's not an error: there used trolleybuses with diesel or hydrogen second engine, and part of routes they goes without wires.
Then I'd like to have a way to uncheck this type of error.
Consider this bus route with the ref 215. It is flagged as having misordered stops, which isn't the case.
My guess is that the error lies within this:
railway=preserved
should be treated as a valid tag for route=train
.
If a bus route has a way tagged as "highway=construction", this flags a warning. Fine!
But the report about the route gives this warning instead: "Street vehicle route over railways = true"
The situation also arises for rail routes, should someone change one of the ways into railway=construction. It is still considered as a railway but the report will say "Railway route over roads = true".
The new trolley buses can operate without trolley wire using the built-in battery. Due to this fact, no trolley wire is required in short distances. Please check this area in Budapest, Hungary. This error report error: trolley bus without trolley wire
cannot be fixed, because the road has no trolley wire at all. The trolley buses operates here by using battery.
I suggest to add an exception to the validator: if trolley_wire=no
is mapped, no error message is displayed. Please add a hint in the error message to the mapper, how can they dismiss this kind of error by adding trolley_wire=no
.
If there is a trolley bus route and no trolley_wire=*
key is added, the error message should be still there.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.