Comments (1)
I see that role checking for stops and platforms is done by means of two string comparison functions, while role checking for ways is just strcmp against the empty string.
possibly enough to replace the various comparisons !strcmp(x->role(), "")
by an invocation is_way(x->role())
of the following function:
bool PTv2Checker::is_way(const char* role) {
return !strcmp(role, "") || !strcmp(role, "hail_and_ride");
}
possibly like this, but you surely want unit tests …
my.patch.gz
from osmi_pubtrans3.
Related Issues (20)
- Duplicated ways at beginning of list of ways triggers an error although it is valid
- Add support for light_rail routes HOT 5
- railway=preserved HOT 1
- Routes without way members with empty roles HOT 2
- Error fields aren't obvious or documented HOT 2
- bus_guideway HOT 1
- Trolley wire is not required for trolley buses HOT 1
- Invalid route flagged but no data provided that is triggering the invalid route. HOT 3
- Support busway HOT 5
- Please, nake check for "trolley bus without trolley wire" optional HOT 3
- Suggestion: Add checks for route=road
- Support route=light_rail
- Fine-granular distinction of invalid routes on HMI
- Route mistakingly flagged as having misorderered stops when a road is included twice
- route passing validation while using road against oneway HOT 2
- Route inspector does not recognize entry_only or exit_only stops HOT 1
- Route inspector does not recognize roundabout=circular
- Confusing error message when relations use a way under construction
- Add missing stations check to subways
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osmi_pubtrans3.