geodacenter / covid-histories Goto Github PK

Plausible has been setup and working properly, time to remove GA.

After reviewing stories and approving them, sometimes a few appear back in the Unreviewed tab after a few minutes, and over time the number of reverted stories increases. I believe this has only happened with stories we uploaded through the admin-upload page, so perhaps #29 is in play as well.

This probably contributed to the problem described in #30, as stories that had moved back to the Unreviewed tab were likely targeted by the Repair AV cron workflow, which I'm now fairly sure was what caused the increase in data transfer.

From Amy:

on "Share your story", it wasn't immediately clear to me that I needed to click "Next" in order to advance, since the front page was scrolling-based (I scrolled down before realizing that the bar was a progress bar) — maybe inverting the colors would make it more obvious?

We have had a jump in our AWS bill over the last week, due to an unanticipated uptick in transfer out expenses, well beyond the free tier and well beyond normal usage of the site. I've put logging in AWS where I can, and, I believe, tracked this activity to GitHub node fetches. The timing of this seems to match up with when we uploaded a large number of files through the admin-upload process after a tabling event.

From Amy:

the scrolling on the front page is a bit inconsistent — it takes a long time to scroll past the initial splash (maybe due to loading the three images on the side?), but the scroll "distance" for the "Your experiences, your medium" page is really short / the rest seems too short in comparison to the length of time spent on the initial landing page as well

From Amy:

email address is currently spelled wrong on the "Signup or Login" landing page (I would also make it "Sign Up or Login" / be consistent about signup vs sign up, since it's inconsistent across a few places right now (I believe it should only be two words — sign-up (hyphenated) is a noun/adjective, while sign up is a verb phrase)

Currently errors (on recording) are mysterious

From Amy:

design-wise, maybe a more handwriting-type/script font for the "your story" / Stories in the logo / other places the font is used? I think the font looks a bit simplistic/a little too neat currently and to my eye, it conflicts with the rest of the design (which is really clean and aesthetically pleasing)

@svijay77 and I spent a while tracking an issue concerning two stories uploaded through the admin-upload page. This stories did appear in the admin pages and were successfully approved, however, they aren't showing up in the US Covid Atlas map.

After digging around, we found a few things:

• In the S3 /uploads folder, the proper files were present, but had a number of extra spaces on the end (also MP4 was capitalized). For example:
  /uploads/<uuid>/<storyid>_meta.json
/uploads/<uuid>/<storyid>.MP4
• In the S3 /public folder, the MP4 file also had the extra spaces
• In the S3 /meta folder, the survey.json file also had the extra spaces, and no <storyid>.json had been created

We manually removed all of these spaces (and changed .MP4 to .mp4) and then ran the Update CDN Github action. This seems to have fixed part of the problem, as the S3 bucket's /public/info.json now contains references to the new stories (we had confirmed before that it didn't, and that's why they weren't on the map). Once CloudFront refreshes that file cache, hopefully these stories will appear on the map.

The survey metadata file is still not created, but we think that may be related to #28.

One interesting thing to note: Before removing the spaces from the file names as described above, the Update CDN workflow was failing with this message:

https://***.s3.***.amazonaws.com/uploads/9d2a8e7b6da6fe1bdede9014a8d31f8637bacfc4/t6xQiL2FOrKtNzB3IerT3_meta.json?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=***%2F20230417%2F***%2Fs3%2Faws4_request&X-Amz-Date=20230417T015241Z&X-Amz-Expires=300&X-Amz-Signature=7e010d27eb4ecf371fec783a48f39558cbffa07b57ba31ae19f818027e096afb&X-Amz-SignedHeaders=host&x-id=GetObject
(node:1822) UnhandledPromiseRejectionWarning: Error: No value provided for input HTTP label: DistributionId.
    at serializeAws_restXmlCreateInvalidationCommand (/home/runner/work/covid-histories/covid-histories/node_modules/@aws-sdk/client-cloudfront/dist-cjs/protocols/Aws_restXml.js:271:15)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async /home/runner/work/covid-histories/covid-histories/node_modules/@aws-sdk/middleware-serde/dist-cjs/serializerMiddleware.js:5:21
    at async /home/runner/work/covid-histories/covid-histories/node_modules/@aws-sdk/middleware-logger/dist-cjs/loggerMiddleware.js:6:22

The number of url params in that expected /uploads/ url is 8, which, we should have counted but didn't, was about the same number of spaces at the end of the files. I have a hunch that something with the pre-signed url generation during this admin-upload process failed, and missing url params were converted into spaces and appended to the new file names.

From amy:

under Your Pandemic Experience / the Your Self tab, "Talk about" is used. "Describe" might be more inclusive than "talk" if this landing page is used for all the submission types?

@svijay77 and I discussed this, looks like the update-surveys workflow has been failing for a number of months, missing a REGION variable for AWS (at least).

To sell people a bit more (or also to fast track to actually viewing stories) show how the stories will look

This may be related to the repair a/v workflow issues that we encountered recently. Need to do a thorough check through, starting with the most recently added videos.

This is a catch-all issue for substantive attack vector concerns moving forward.

Suggestions included depictions of work, pallbearers wearing masks.

• Add API route(s) to tag accepted / rejected and comments
• Add pre-manual review NSFW checker
• Add get new entry API route
• Add admin-only frontend to review pages

The phrase "unexpected changes" didn't quite reflect the inequitable racial and social impacts of COVID-19 and the pandemic, and CAB members requested more explicit language.