Giter Club home page Giter Club logo

barty's People

Contributors

dependabot[bot] avatar galliotl avatar lorenzomp avatar timutt avatar

Stargazers

 avatar  avatar

Watchers

 avatar

barty's Issues

Regex verification

Mettre en place des vérifications regex sur les différents champs des méthodes createBarController et userSignupController

getBarController ne fonctionne pas

Je ne comprends pas pourquoi mais même en passant l'id dans le body de la requête get, la réponse est toujours "couldn't retreive this bar".
D'ailleurs on a la même réponse si on ne fournit pas d'id, ce qui ne devrait pas être le cas.

Implement login/signup pages

The workflow is to be determined but we can still implement the basic elements and pages.

This includes the textfield component and the form shape that can be found in the following image:

image

Make buttons gradient

You can create a random container decorated with a gradient and use InkWell to add splash color afterwards

Add github PR safety nets

Is your feature request related to a problem? Please describe.
No restrictions are currently in place to add code in the code base. This is dangerous

Describe the solution you'd like
Add restrictions of at least 1 CI github action validation + 1 peer review

Describe alternatives you've considered
Force documentation

Modifier createBarController

Dans le createBarController, réfléchir à quels paramètres doivent réellement être obligatoires à la création (pas event par exemple)

Add Unit testing for the Api Express js controllers

Is your feature request related to a problem? Please describe.
We currently don't have any way to prove code regression if any. Indeed, no tests are made so one can clearly push code that's wrong and worse, breaks already existing code

Describe the solution you'd like
Adding a testing framework to the project and implementing it

Describe alternatives you've considered

  • Manual testing: fine at first but unbearable afterwards

Additional context
Tests are automatically done now with github actions so it's really not a hassle to test the whole project

Un meilleur endpoint que Lorenzo

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Add unit testing

Is your feature request related to a problem? Please describe.
Currently no tests are being made before uploading.

Describe the solution you'd like
a test folder should be implemented in the src folder conainig all the tests files. We should use mocha as it is the most widely spread library.

Additional context
Putting it in CI would be a great idea

Créer un model (interface et schema) “adressBar”

Créer un model (interface et schema) “adressBar” qui contiennent les champs [streetAdress: string; city: string;state:string;postalCode:number;country:string]
et utiliser ce schéma à la place de String pour stocker les adresses des bars

Change backend project structure to be less separated

Is your feature request related to a problem? Please describe.
Separation could be done later on. Rn, it adds a lot of not needed issues for a project not yet live.

Describe the solution you'd like
A folder with all the routes and handlers

Create a resilient backend for auth

Currently auth server is pretty shitty and basic. We should create a new workflow for it where:

  • the user sends his phone and we add him directly in the database
  • the user sends his code for the signup instead of "isPhoneConfirmed = true"
  • then the rest is added to the db

updateBarController

Faire en sorte qu'on puisse modifier un bar et checker si ça met à jour le updatedAt (timestamp)

stocker les horaires

Trouver un moyen de stocker les heures et minutes pour les horaires d’ouverture et de fermeture des bars (il n’existe que l’objet Date et pas d’objet time dans mangoDB, donc il faudrait peut être créer un model “time” qui contiennent [hour:Number;minute:Number] )

Add github actions

delete what's not used

Add github actions

Short description

In order to automate some basic tests and prevent failing code to enter the codebase, we should add github actions as part of our integration process

TODO:

  • Add github node action
  • Add github dart action

CRUD event

qu'un bar puisse créer modifier supprimer un event et que tous les users puisse le voir

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.