fusion-energy / spectrum_plotter Goto Github PK

The plots are not the same, looks like the side the step is on is different

Currently the y_err value just adds to the y value and subtracts to make a shadow region either side.

However it would be better if this was a multiplication as the y_err is actually the standard deviation.

Then another argument for sigma can be added to allow users to input 1 sigma but plot 2 , 3 or more sigma error

It would be quicker using the openmc dockerimage instead of the openmc-dagmc docker image
the openmc-dagmc-wrapper could be removed if the tallies in the examples were created with regular openmc commands
the examples could all read from the same statepoint file instead of including simulations
add information on creating the statepoitn file to the readme

It would be nice to allow per unit lethargy axis options to the plots

this would need to get the energy bin width as part of the calculation

How would folk feel about making the openmc tally unit convertor optional either something along the lines of

 try:
        import external_module
    except ImportError:
        external_module = None 

or moving the import into the plot_spectrum_from_tally function?

Looks like current on a surface is not a supported tally. I guess this should be added in openmc_tally_unit_convertor so that it can be used here

overly aggressive weight windows can cause the spectrum to have gaps. While this is not ideal the package should properly handle this without crashing.

• add test case to mimic gappy spectrum and reproduce error
• add solution to handle gappy spectrum

The pip install gets the openmc_tally_unit_convertor, this in turn is dependant on having openmc installed which is not retrieved.
The pip install alone does not give a working spectrum plotter

matplotlib can perhaps be the default but it would be handy to have a plotly option for those interactive plots.

then the neutronics work shop can make use of this package to plot spectra in a few tasks

The volume argument might not be working and a test needs adding to check

This could be done by making two plots one with the required_units that are flux/volume and one with no special required_units.

The plot object that is returned could then be inspected to make sure the y values have been changed accordingly