Giter Club home page Giter Club logo

Comments (3)

shimwell avatar shimwell commented on July 28, 2024

Sure we can do this if it helps you in anyway. Feel free to make a PR and we can merge it in.

The openmc_tally_unit_converter is quite minimal, as in it doesn't actually have any dependencies that are not already needed by spectrum plotter. So I can't quite see the benefits myself but if you want it then we will do it

from spectrum_plotter.

py1sl avatar py1sl commented on July 28, 2024

Spectrum plotter doesn't import openMC directly only via openmc_tally_unit_converter
This change would in future allow spectrum plotter to be extended to other codes / be code agnostic allowing consistent plotting with different codes without needing to install openMC.

from spectrum_plotter.

shimwell avatar shimwell commented on July 28, 2024

Fair enough. Sometimes I forget there are other codes 😄

Feel free to make a PR and we can merge it in

from spectrum_plotter.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.