fundersclub / django-papertrail Goto Github PK

TemplateDoesNotExist at /django-admin/users/user/749/change/
admin:admin/change_form.html

I suppose this would work only when https://github.com/django-admin-tools/django-admin-tools/blob/master/admin_tools/template_loaders.py is used but this is not stated anywhere in the docs, unfortunately.

When an object changes many times the list of changes grow. At the moment is not possible to have pagination on this. I created a pull request with an implementation of the pagination for this particular case. #12

Happy to discuss alternatives and put the time to fix this.

Title is self explanatory, needs some updates to be compatible with Django 2.0 breaking changes.

Not sure where it should live. Main app?

Per the "Primary key type compatibility" section, it feels like we should be able to support other pk types using get_db_prep_value():
https://docs.djangoproject.com/ja/1.9/ref/contrib/contenttypes/#django.contrib.contenttypes.fields.GenericForeignKey.for_concrete_model

Undocumented in django-papertrail is that all objects in "target" must be registered with Django's ModelAdmin, or otherwise loading the log message's page in the Django admin panel will fail ungracefully. I see a couple of ways forward here:

1. This could simply be a documentation fix.
2. We could check targets at the time they're added to django-papertrail to see whether these targets are part of ModelAdmin, and raise an error if they are not. This has the weakness that if at some point in the future a model was removed from the ModelAdmin, this error would occur and be difficult to understand or debug.
3. We could check in the admin_reverse_for_model function whether said model is in ModelAdmin (or catch the error here when the reverse isn't found), and if it's not then simply print a warning in place of the ModelAdmin link that a developer needs to add said model to ModelAdmin in order for it to be visible in django-papertrail.

I love django-papertrail, and if you advise on your favorite approach to resolving this issue, I'd be happy to submit a PR.

Is it possible for papertrail to hook into all models and log their changes. I want to have a list of:
user, model class, attrbiute, old_value, new_value, timestamp.

From what I can tell in the docs such integration isn't possible. From what I can figure out of Django's model signals we don't have information about which is the current user who performs the action but we do have info if an object was created/deleted and what fields were up for an update.

Hi your package is useful. I appreciate your reusable app very much.
After I read your document I tough targets is able to do generic relation and reverse query back to the original record. Therefore I put my Company and Branch instance to it and it raises the error

TypeError: int() argument must be a string, a bytes-like object or a number, not 'Company'

targets = {
            'company': company,
            'branch': branch,
        }

Do you have plan to expand the feature to cover arbitrary instance?