Giter Club home page Giter Club logo

Comments (3)

eranrund avatar eranrund commented on July 3, 2024

We might want to reconsider this, @chazeah:

  1. It requires some ugly hacks (please see https://github.com/FundersClub/django-papertrail/compare/feature/varchar-related-ids). Seems to work fine with those hacks (tests pass on Django 1.8/1.9), but who knows if it'll come bite us in the ass at a later point.
  2. I don't know if these impose any significant performance penalties or not - I can look into it, but there's a chance they do.
  3. Since one of the hack uses Func it means we'll need to drop Django1.7 support (fine by me).

Other than our internal apps which (made the mistake, in my opinion - not only it surfaces issues such as this, but it is also significantly more expensive to store/compare) of using non-standard primary keys, we haven't seen a demand for this.

from django-papertrail.

chazeah avatar chazeah commented on July 3, 2024

As the primary maintainer of papertrail, I look to you for a strong opinion on whether this change introduces unnecessary complexity and overhead. It definitely complicates things, and for only a small upside. Defer to you on path forward.

from django-papertrail.

eranrund avatar eranrund commented on July 3, 2024

Going to skip this for now. If a justified need arises in the future I'll re-evaluate. I don't feel like such a need has been demonstrated at this point.

from django-papertrail.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.