fulls1z3 / example-app Goto Github PK

I'm submitting a ... (check one with "x")

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please check the repository for a similar issue or PR before submitting -->
[ ] Support request => <!-- Please check the repository for a similar issue or PR before submitting -->
[x] Feature request
[ ] Documentation issue or request

Current behavior

Expected/desired behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

• Angular version: X.Y.Z

• Browser:

• Chrome (desktop) version XX
• Chrome (Android) version XX
• Chrome (iOS) version XX
• Firefox version XX
• Safari (desktop) version XX
• Safari (iOS) version XX
• IE version XX
• Edge version XX

• For Tooling issues:

• Node version: XX
• Platform:

• Others:

I'm submitting a ... (check one with "x")

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  <!-- Please check the repository for a similar issue or PR before submitting -->
[ ] Support request => <!-- Please check the repository for a similar issue or PR before submitting -->
[x] Feature request
[ ] Documentation issue or request

Current behavior

Expected/desired behavior

• public members without prefix & private members with underscore _ prefix
• add JSDocs

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

• https://github.com/angular/material2/blob/master/CODING_STANDARDS.md
• https://google.github.io/styleguide/jsguide.html
• https://github.com/ng-seed/angular-tslint-rules/issues/8

Environment

• Angular version: X.Y.Z

• Browser:

• Chrome (desktop) version XX
• Chrome (Android) version XX
• Chrome (iOS) version XX
• Firefox version XX
• Safari (desktop) version XX
• Safari (iOS) version XX
• IE version XX
• Edge version XX

• For Tooling issues:

• Node version: XX
• Platform:

• Others:

Any plan to upgrade the project to use angular 6?

best,

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because we are using your CI build statuses to figure out when to notify you about breaking changes.

Since we did not receive a CI status on the greenkeeper/initial branch, we assume that you still need to configure it.

If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with greenkeeper/.

We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

Once you have installed CI on this repository, you’ll need to re-trigger Greenkeeper’s initial Pull Request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper integration’s white list on Github. You'll find this list on your repo or organiszation’s settings page, under Installed GitHub Apps.

I'm submitting a ... (check one with "x")

[ ] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[X] feature request

Current behavior

Expected/desired behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

• Angular version: 2.0.X

• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

• Language: [all | TypeScript X.X | ES6/7 | ES5]

• Node (for AoT issues): node --version =

The devDependency @types/jasmine was updated from 2.8.8 to 2.8.9.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/jasmine is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Unhandled Promise rejection: Invalid configuration of route 'marketing': children and loadChildren cannot be used together ; Zone: ; Task: Promise.then ; Value: Error: Invalid configuration of route 'marketing': children and loadChildren cannot be used together

I'm submitting a ... (check one with "x")

[X] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[ ] feature request

Current behavior
After updating Angular to 2.4.8 (@angular/router 3.4.8), the application gets started only on root url.

You can navigate within the app using the routerLink directive. For instance, you can start the app on http://localhost:4200/ and navigate to http://localhost:4200/en/about.

But, when you type at the address bar http://localhost:4200/en/about, the app starts at http://localhost:4200/ - instead of http://localhost:4200/en/about.

Expected/desired behavior
When you type at the address bar http://localhost:4200/en/about, the app must start at http://localhost:4200/en/about.

Minimal reproduction of the problem with instructions
Check the source on @nglibs/example-app

What is the motivation / use case for changing the behavior?
Please check:

• angular/angular#14588
• angular/angular#12162
• angular/angular#14327

Please tell us about your environment:

• Angular version: 2.0.X
  2.4.8 (@angular/router 3.4.8)

• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  all

• Language: [all | TypeScript X.X | ES6/7 | ES5]
  TypeScript 2.0.x, TypeScript 2.1.x

• Node (for AoT issues): node --version =
  v6.9.1

The dependency lodash was updated from 4.17.10 to 4.17.11.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

lodash is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because we are using your CI build statuses to figure out when to notify you about breaking changes.

Since we did not receive a CI status on the greenkeeper/initial branch, we assume that you still need to configure it.

If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with greenkeeper/.

We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

Once you have installed CI on this repository, you’ll need to re-trigger Greenkeeper’s initial Pull Request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper integration’s white list on Github. You'll find this list on your repo or organiszation’s settings page, under Installed GitHub Apps.

The devDependency @types/jasminewd2 was updated from 2.0.3 to 2.0.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/jasminewd2 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I'm submitting a ... (check one with "x")

[X] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[ ] feature request

See fulls1z3/universal#11 for details

I use commands "npm run build:spa-dev" and "npm run build:spa-prod"
and get this:
[16:22:41] Using gulpfile ~\Documents\helpers\universal\gulpfile.js
[16:22:41] Starting 'clean'...
[16:22:41] Starting 'clean:public'...
[16:22:41] Finished 'clean:public' after 11 ms
[16:22:41] Starting 'clean:server'...
[16:22:41] Finished 'clean:server' after 6.12 ms
[16:22:41] Starting 'clean:cache'...
[16:22:41] Finished 'clean:cache' after 2.61 ms
[16:22:41] Starting 'clean:temp'...
[16:22:41] Finished 'clean:temp' after 1.79 ms
[16:22:41] Finished 'clean' after 29 ms
[16:22:44] Using gulpfile ~\Documents\helpers\universal\gulpfile.js
[16:22:44] Starting 'build:spa-dev'...
[16:22:44] Starting 'dummy'...
[16:22:44] Finished 'dummy' after 1.83 ms
[16:22:44] Starting 'bundle:spa-dev'...
[16:22:45] 'bundle:spa-dev' errored after 384 ms
[16:22:45] SyntaxError: Unexpected token {
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:373:25)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Module.require (module.js:353:17)
at require (internal/module.js:12:17)
at Object. (C:\Users\user\Documents\helpers\universal\node_modules@ngtools\webpack\src\index.js:30:10)
at Module._compile (module.js:409:26)
at Object.Module._extensions..js (module.js:416:10)
[16:22:45] 'build:spa-dev' errored after 403 ms