frappe / drive Goto Github PK

A feature to select and download multiple files and/or folders will be a great feature.

I had Erpnext production installed in a web server erp.example.com . Later I installed Frappe Drive.

Now when I login to erp.example.com, instead of erp.example.com/app, now it goes to erp.example.com/drive. What I wanted is, it logged in as usual but at the sidebar in erpnext, a link appeared that takes to Drive.

Hello Frappe, community. Awesome apps you guys are brewing lately!

Frappe Drive seem like it can basically replace our Nextcloud in many ways, and allow our users to have a single-source-of-truth in a single Frappe / ERPNext instance :)

Just one feature request to make it happen for us though, can you guys look into "disallow download" when sharing a document with a user? It'll mostly be .pdfs and user should be able to view the document.

Perhaps the document is sensitive, and company policy does not allow employees to download certain documents. Certain users will be able to get into the source code of the system, or take screenshots, that's fine :) it's just the policy is there, so system should follow.

Hello Frappe, community.

I came across another feature request that makes sense.

Can we have the option to share a document, or maybe a folder with users under a specific role? Like, create a folder named "Company policy" and be able to share it with users with the Employee role.

Thanks!

When i try to share a file, or copy a link i get error both ways.. I tried with invite but i get an error aswell..

When i try invite i get: Cannot read properties of undefined (reading 'exc_type')
When i try to copy link i get: Some error occured while copying the link

check for orphaned drive entities & handle plausible failing of permanent deletion of files.
have some sort of cron that cleans up the mess and helps maintain drive integrity

There are some plan about viewer?

What is the right way to install / use Drive in production server ?

these steps that i follow to use Drive

1. get-app
2. install-app
3. go to /drive/frontend/ and run yarn build
4. I found there is files generated in public/frontend/ folder

and in the server i try to access /drive i get 404 error

could you help and create installation steps in production server plz.?

I created two folders A and B. I also uploaded a sample.txt file.
It should be possible to move folder A into folder B by drag and drop.
It should be possible to move sample.txt file into folder B by drag and drop.

File, Edit, Format etc

I have Frappe drive running. However, when accessing it on the network, I am taken to the sign-in page where i need to either login or sign-up. What are the default login details? I can't sigup either.

I've uploaded a bunch of files on drive and want to edit them, I cannot.

Like the home page

Apps Installed

• Wiki
• Chat
• ERPNext
• Helpdesk
• HR
• Payments

The drive page doesn't show up. I tried it on one of my sites on the frappecloud

While testing out Drive, one of the first things that was obviously missing to me was a context menu on folders and files. This POC just takes the options that would available from the 'Actions' Menu and puts them into a context menu.

Frappe-UI's Dialog class is not a good fit for this use case and the ListItem component also wasn't much help, so this is minimally styled with semantic HTML elements.

I've done enough work to get this to open and function correctly, but there are some behaviors that still need attention. I'm at a spot where this feature needs some feedback. And I'd like to understand likelihood that it will be accepted, otherwise I am happy to continue additional development on a fork.

File name should be separate from content

“Tag” Option can will enable to categorize the content and contribute to search as well

AGPL

logged in as a website user (login with Frappe), got no role assigned (by default). then got the following error.

Traceback (most recent call last):
  File "apps/frappe/frappe/app.py", line 83, in application
    response = frappe.api.handle()
  File "apps/frappe/frappe/api.py", line 53, in handle
    return _RESTAPIHandler(call, doctype, name).get_response()
  File "apps/frappe/frappe/api.py", line 69, in get_response
    return self.handle_method()
  File "apps/frappe/frappe/api.py", line 79, in handle_method
    return frappe.handler.handle()
  File "apps/frappe/frappe/handler.py", line 48, in handle
    data = execute_cmd(cmd)
  File "apps/frappe/frappe/handler.py", line 86, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "apps/frappe/frappe/__init__.py", line 1650, in call
    return fn(*args, **newargs)
  File "apps/frappe/frappe/utils/typing_validations.py", line 30, in wrapper
    return func(*args, **kwargs)
  File "apps/drive/drive/api/files.py", line 421, in get_entity
    frappe.throw(
  File "apps/frappe/frappe/__init__.py", line 550, in throw
    msgprint(
  File "apps/frappe/frappe/__init__.py", line 518, in msgprint
    _raise_exception()
  File "apps/frappe/frappe/__init__.py", line 467, in _raise_exception
    raise raise_exception(msg)
frappe.exceptions.PermissionError: Cannot access path due to insufficient permissions

Recent-5d1a3bd8.js:1 Object
Recent-5d1a3bd8.js:1 Error: /api/method/drive.api.files.get_entity PermissionError
    at frappe-ui-71ce1c0a.js:5:2440
    at Generator.next (<anonymous>)
    at s (frappe-ui-71ce1c0a.js:1:660)

Shouldn't I get assigned some role by default?

In the Entity View need to have Files Count for a Folder Entity.

Hello community, Frappe devs :)

As I'm starting to use this app with couple of my co-workers, and really liking this, I came with another area where an improvement could be implemented. Which is:

Show Shared With Me files along with my own uploaded apps in Home. Or perhaps a Drive Settings to make that happen so it doesn't affect everyone else..?

Thanks guys, hope you consider this one along with my other feature requests :)

When i try to see files example PDF files on mobile they dont open, its not compatible with other openings aswell.
Can we have an update about it? or a way to fix it

Hello,

Is there a way to show icon previews for folders of images and videos?

some users have broken profile images, not sure what's the reason

• For when a large file is being uploaded, and it's irrecoverably interrupted (wipe/rename the failed upload)
• Duplicate files (suggest rename or replace dialogue)
• Existing Folders (suggest merge or rename dialogue)
• dropzone.js defaults to retryChunks: false

check for indiviual chunk fails while upload and retry the same

I created a document and then went to File > Delete

Showed me that it was deleting 32 items. Unsure which 32.

To replicate:

1. Upload a file
2. Make public
3. Share link

"await navigator.clipboard.writeText(link)" line 291 of drive/frontend/src/components/ShareDialog.vue does not copy the link.

With a change in the code I get it to perform the copy correctly. It is not an elegant development but I leave it here in case it can serve to guide a solution.

  try {
    await navigator.clipboard.writeText(link);
    this.alertMessage = "Link copied successfully";
    this.showAlert = true;
  } catch ($e) {
    try {
      await forceWrite(link);
      this.alertMessage = "Link copied successfully__";
      this.showAlert = true;
    } catch ($e) {
      this.alertMessage = "Some error occurred while copying the link";
      this.showAlert = true;
    }
  }

function forceWrite(link) {
    return new Promise((resolve, reject) => {
        if (typeof navigator !== "undefined" && typeof navigator.clipboard !== "undefined" && navigator.permissions !== "undefined") {
            const type = "text/plain";
            const blob = new Blob([link], { type });
            const data = [new ClipboardItem({ [type]: blob })];
            navigator.permissions.query({name: "clipboard-write"}).then((permission) => {
                if (permission.state === "granted" || permission.state === "prompt") {
                    navigator.clipboard.write(data).then(resolve, reject).catch(reject);
                }
                else {
                    reject(new Error("Permission denied the copy of the link is not possible"));
                }
            });
        }
        else if (document.queryCommandSupported && document.queryCommandSupported("copy")) {
            var textarea = document.createElement("textarea");
            textarea.textContent = link;
            textarea.style.position = "fixed";
            textarea.style.width = '2em';
            textarea.style.height = '2em';
            textarea.style.padding = 0;
            textarea.style.border = 'none';
            textarea.style.outline = 'none';
            textarea.style.boxShadow = 'none';
            textarea.style.background = 'transparent';
            document.body.appendChild(textarea);
            textarea.focus();
            textarea.select();
            try {
                document.execCommand("copy");
                document.body.removeChild(textarea);
                resolve();
            }
            catch (e) {
                document.body.removeChild(textarea);
                reject(e);
            }
        }
        else {
            reject(new Error("No method has made the copy of the link"));
        }
    });    
}

frappe drive. can work with subdomain ? on mult type

Feature Request: Can we have a feature that who has viewed and downloaded the shared content?

This functionality will be helpful when we shared an important document to someone and that we can track user has viewed or downloaded.

The folder is not getting uploaded.
In Download option multiple files are not getting downloaded.

I've uninstalled and re-installed the app on one of my sites, and now I can't seem to create folders or upload files. I get the following error:

`Traceback (most recent call last):
File "apps/drive/drive/api/files.py", line 101, in create_folder
user_directory = get_user_directory()
File "apps/drive/drive/utils/files.py", line 53, in get_user_directory
raise FileNotFoundError('User directory does not exist')
FileNotFoundError: User directory does not exist

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "apps/frappe/frappe/app.py", line 69, in application
response = frappe.api.handle()
File "apps/frappe/frappe/api.py", line 54, in handle
return frappe.handler.handle()
File "apps/frappe/frappe/handler.py", line 45, in handle
data = execute_cmd(cmd)
File "apps/frappe/frappe/handler.py", line 83, in execute_cmd
return frappe.call(method, **frappe.form_dict)
File "apps/frappe/frappe/init.py", line 1585, in call
return fn(*args, **newargs)
File "apps/drive/drive/api/files.py", line 103, in create_folder
user_directory = create_user_directory()
File "apps/drive/drive/utils/files.py", line 19, in create_user_directory
user_directory_path.mkdir(exist_ok=False)
File "/usr/lib/python3.10/pathlib.py", line 1175, in mkdir
self._accessor.mkdir(self, mode)
FileExistsError: [Errno 17] File exists: 'my.site/private/7b7bc2512ee1fedcd76bdc68926d4f7b'`

Uninstalling the app and re-installing again does not fix the issue. What can I do at this point?

It so happens that an entity record in DB gets deleted but the corresponding actual file on disk does not get deleted due to various plausible OS level stuff, namely (File not found, Invalid path, I/O errors, Race conditions).

As of now.., every file is being recursively deleted using Path.unlink() in a sequential manner, which is very bad in terms of performance and otherwise.

Ideally, we should use shutil.rmtree() ...
and "batch" remove all entity records from DB corresponding to actual files within the directory .
instead of manually deleting one file after the other.

• Overall project goals
• Current screenshots

drive 0.0.1
erpnext 13.27.0
frappe 13.26.1

16:58:53 web.1            | 127.0.0.1 - - [15/Sep/2022 16:58:53] "POST /api/method/drive.api.files.list_folder_contents HTTP/1.1" 200 -
16:59:00 web.1            | Traceback (most recent call last):
16:59:00 web.1            |   File "apps/frappe/frappe/app.py", line 69, in application
16:59:00 web.1            |     response = frappe.api.handle()
16:59:00 web.1            |   File "apps/frappe/frappe/api.py", line 55, in handle
16:59:00 web.1            |     return frappe.handler.handle()
16:59:00 web.1            |   File "apps/frappe/frappe/handler.py", line 37, in handle
16:59:00 web.1            |     data = execute_cmd(cmd)
16:59:00 web.1            |   File "apps/frappe/frappe/handler.py", line 75, in execute_cmd
16:59:00 web.1            |     return frappe.call(method, **frappe.form_dict)
16:59:00 web.1            |   File "apps/frappe/frappe/__init__.py", line 1447, in call
16:59:00 web.1            |     return fn(*args, **newargs)
16:59:00 web.1            |   File "apps/drive/drive/api/files.py", line 122, in create_folder
16:59:00 web.1            |     drive_entity.share(frappe.session.user, write=1, share=1)
16:59:00 web.1            |   File "apps/drive/drive/drive/doctype/drive_entity/drive_entity.py", line 151, in share
16:59:00 web.1            |     for child in self.get_children():
16:59:00 web.1            | AttributeError: 'DriveEntity' object has no attribute 'get_children'
16:59:00 web.1            |
16:59:00 web.1            | Traceback (most recent call last):
16:59:00 web.1            |   File "apps/frappe/frappe/app.py", line 69, in application
16:59:00 web.1            |     response = frappe.api.handle()
16:59:00 web.1            |   File "apps/frappe/frappe/api.py", line 55, in handle
16:59:00 web.1            |     return frappe.handler.handle()
16:59:00 web.1            |   File "apps/frappe/frappe/handler.py", line 37, in handle
16:59:00 web.1            |     data = execute_cmd(cmd)
16:59:00 web.1            |   File "apps/frappe/frappe/handler.py", line 75, in execute_cmd
16:59:00 web.1            |     return frappe.call(method, **frappe.form_dict)
16:59:00 web.1            |   File "apps/frappe/frappe/__init__.py", line 1447, in call
16:59:00 web.1            |     return fn(*args, **newargs)
16:59:00 web.1            |   File "apps/drive/drive/api/files.py", line 122, in create_folder
16:59:00 web.1            |     drive_entity.share(frappe.session.user, write=1, share=1)
16:59:00 web.1            |   File "apps/drive/drive/drive/doctype/drive_entity/drive_entity.py", line 151, in share
16:59:00 web.1            |     for child in self.get_children():
16:59:00 web.1            | AttributeError: 'DriveEntity' object has no attribute 'get_children'

Changing size to small and back to normal fails.

It will be nice to have preview for audio & video assets.
Thanks for the wonderful product

When I upload file and create new folder its given error.

Is it possible to use frappe drive as a user interface while saving the data in a Google Drive?