document viewer about drive HOT 13 CLOSED

@chensce Not all MIME types are currently handled, but PDFs and images look good to me in the viewer. What types were you looking for?

from drive.

ppt，docs，excel

from drive.

mp4，mp3

from drive.

thank you！😄

from drive.

@chensce there are no immediate plans, but do we do plan on adding these some time in the future.

from drive.

@krantheman Akash, I'd like to propose a plan to prioritize preview elements (edit: as in which ones to contribute first) and a pattern to add custom viewers (and possibly MIMEType icons). There's a large group of file types that makes sense to incorporate viewers for, but there will be others that are going to be industry specific. I think that an API that allows you to extend Drive by offering a custom preview could be really valuable. I can rough out a design for this, but want to understand your level of interest first.

from drive.

@agritheory sure, what file types are you thinking?

from drive.

@krantheman What I am thinking is going for the most surface area (file types by percentage) while also keeping dependencies to a minimum.
First round, I'd like to propose previews for five MIME types: markdown, CSV, XLS, XLSX and ODT. Markdown can be handled with existing dependencies, The others are handled by the same package: https://www.npmjs.com/package/excel-viewer
Second round seems like DOC, DOCX and the Open Office / Libre office format, but there isn't a clear shortcut there like there is with the spreadsheet category: https://www.npmjs.com/search?q=docx
Slides / PowerPoint after that, I haven't looked into dependencies for these.
Then video and audio, where there are lots of options but it makes sense to use the same deps as the Frappe framework's A/V stack.
We don't need to solve for all files, we need to solve for the most encountered ones. There's always going to be some file type that is specific and common to one use case and would never be used in another. A manufacturer might often need to share drawings (DXF is one of the most common) but that's something a software development business would like never need to deal with. Providing an API where Drive can be extended to support arbitrary previews would be an excellent feature, but getting some of the most common previews built in should be the first step.

from drive.

@agritheory Hmm, sounds good to me. Are you willing to contribute to the development of this?

from drive.

@krantheman Yes. I'll try my hand at the markdown previewer first and then the spreadsheets. That will give enough of a body of work to know if there should be a design change.

from drive.

@agritheory Cool! Also, I think I should let you know that there are plans to implement the frappe-ui text editor for simple text editing. I haven't dabbled enough to know about its usage though.

from drive.

@krantheman Yes. I'll try my hand at the markdown previewer first and then the spreadsheets. That will give enough of a body of work to know if there should be a design change.

my frappe drive will not open why?

from drive.

Initial implementations of Docx, xlsx, txt (json,py,js basically any text file) are done.

from drive.