"Get location" feature is not working if the system decimal separator is "," - the program fetches location but cannot interpret it correctly.

The gps prefs (minAge, maxAge, and maxElapsed) appear to be ignored - the defaults are always used.

Allow translations to supply their own default lat/lon, so that even a poorly configured app displays reasonable looking times.

At the moment the default is hardcoded from WidgetSettings. There is the configHint_location_lat and lon values but they are strictly textview hints (and should probably indicate the expected format (DD) vs suggesting a default).

The timezone setting is being ignored when displaying 24 hour time.

It always displays using the system timezone, while displaying a mismatching label. Swapping timezones appears to do nothing, and if you aren't already aware of what the times are supposed to be beforehand, it makes it look like the calculation is completely wrong. If you are using a locale that toggles the 24hr time setting (de vs en), the problem appears to be locale dependent. Since custom timezone is off by default its not immediately noticeable.

using default lat/lon 35, -112...
System Settings -> Date & Time -> 24hr time -> on
System Settings -> Date & Time -> Select timezone -> America/New York
Suntimes App -> custom timezone -> America/Phoenix .. the reported sunrise time is ~ 08:45 (right time for new york, but is actually 5:45 in phoenix)

System Settings -> Date & Time -> 24hr time -> off
System Settings -> Date & Time -> Select timezone -> America/New York
Suntimes App -> custom timezone -> America/Phoenix .. the reported sunrise time is ~ 05:45 (right time)

The bug is present in v0.1.0, v0.1.1.

Ahoi,
in the general settings, there is only a %s "selected" as the Data Source by default.

Greetings
HerHde

Fix the widget preview; it currently shows 'example', at minimum it should show the half circle drawables.

Hello, I'm Denis Bogdanas, a research assistant at Oregon Stat University.
I'm working on a tool that automatically introduces runtime permission checks and requests for Android 6 apps. As part of this study I analyzed this app. I was looking at the way permissions are referred in the code.

This app declares permissions <ACCESS_COARSE_LOCATION> in the apk manifest, but doesn't have any code that requires them. It is possible that source code doesn't declare the permissions. I only analyzed apk builds from f-droid. Yet android build mechanism may introduce them when the app uses certain libraries:

https://commonsware.com/blog/2015/06/25/hey-where-did-these-permissions-come-from.html

It won't create any problems on Android 6, but on Android 5- users may wonder why the app needs these permissions and be skeptical of installing the app.

Do you think this is an issue?

best regards,
Denis

The "Export Places" and "Clear Places" items are non-functional. They respond to taps but no action occurs - the export/clear dialogs should be displayed.

tested using v0.2.1 against api 10.

Ahoi!
First of all: Thank you very, very much for this app. I had a widget for sunrise/-set on my whishlist for months, now I found it on F-Droid.

I want to contibute a german translation. It seems that you there is no internationalisation yet, how can I help you without coding in java?

Also there is a file named app/src/main/res/values/styles.xml~, are you using emacs? ;-)

Ahoi,
could you give me some help with the german translation, please?

1.- daylenght - could you please explain those to me? How are they calculated, which differences are this?

    <!-- Field: length of day
         The hours in the day field(s) that appears below the table (main activity).
         (layout/info_time_daylength.xml)
    -->
    <string name="length_day">in the day</string>
    <string name="length_light">of usable light</string>

2.- daydelta - where do these strings appear?

  <!-- Field: today/tomorrow time delta
       (layout/info_time_daydelta.xml)
  -->
  <string name="delta_day_tomorrow">Tomorrow will be</string>
  <string name="delta_day_yesterday">Yesterday was</string>

3.- Note - I've translated it as Kurzinfo, which means something like short information, don't know any better approach yet, because note is Notiz in german, which primarily means memo, a little bit misleading IMHO.

4.- Widget Setting: date mode - I can't find these within the app?!?

  <string name="configLabel_date">Date Settings</string>
  <string name="configLabel_date_mode">Mode:</string>
  <string name="configLabel_date_custom">Date:</string>

5.- gps_lastfix, gps_keeptrying and the toast - Could you please provide a screenshot of their appearance?

Except of these, the translation is almost ready for a first release ;-)

Greetings
~HerHde

All times are very wrong as sunrises are shown during the middle of the day for example. It seems that somehow it doesn't get the right time from the system.

Add an option to display in either "local mean time" or "apparent solar time" in addition to current option to change the timezone.

To implement... change the "time zone" dialog into a "time mode" dialog and add a new mode "solar time" (in addition to "system time zone" and "user-defined time zone"). When selected it offers a choice between "local mean time" and "apparent solar time".

Nuntempe mi tradukas la Suntimes aplikaĵon al la Pola (pl) lingvo, poste mi volos fari Esperantan (eo) tradukon. Ĉu vi povus aldoni agordon por ŝanĝi lingvon de programo? Tio estas grava precipe por Esperanto, ĉar ĝi ne povas esti elektita en Android kiel ĉefa lingvo de sistemo...

Now I'm translating the Suntimes app into Polish (pl) language, later I want to make translation into Esperanto (eo). Could you add setting to change program language? This is important especially for Esperanto, because it cannot be selected in Android as default system language...

An upgrade from 0.2.1 → 0.2.2 asks for these new permissions:

• Modify or delete the contents of your SD card
• Test access to protected storage

I could not find either in the changelog or the code what they might be used for. Would it be possible to clarify? Cheers 😃

The custom language listpref should be disabled when the mode is set to system but it is not. It is possible to select a custom language (and have the app update to that language) despite the mode being set to system.

tested using v0.2.1 against api10

I've checked on 2 phones (with smaller and bigger screen) and times of sunsets and solar-noon go out of the screen on both Polish, Esperanto and German translations. What can be do to fix it:

1. Shorten the strings "sunrise_short" and "sunset_short", eo/pl versions are ready, now @HerHde needs to update German translation.
2. The date is currently displayed in 2 lines "Today |next-line| 2016-08-16", maybe in similar way display the column "Rise" and "Set" - display the icon of Sun above or in the next line.
3. There's lots of unoccupied space between a date and the word "Rise", so maybe align the column "Set" to the right corner of screen, and make width of column "Date" variable.

Show a warning icon next to the datefield when configured to the past. I overlooked the "past" label while pressed for time on a recent hike, so the potential for confusion definitely exists. Draw attention to the date when the configuration is out of the ordinary.

Add a "widget preview" to the configuration activity that shows what the widget will look like if added with the currently selected settings.

I love your app
I have been using a outdated app for years
It's nice to see a new app being developed
I would love to see a feature to track
Summer and winter solstice (longest and shortest days of the year)
maybe even a count down between solstice widget option

Keep up the great work.
I get your app from fdroid.It's nice to see it there.

Create an About activity:

• one line app desc
• link to: this project
• link to: mikereedell/sunrisesunset-java
• legal stuff: copyright & gplv3 notice
• instructions for configuring / using the widget

Using a user-defined timezone set to UTC, the rise time is 1:24PM UTC and set time is 1:16AM UTC (next day). The solar noon time should be 7:20 PM, but instead shown as 7:20AM. When using the system timezone the solar noon time is correctly shown as 12:20PM, and when using other user-defined timezones (EST for example) the solar noon time is correctly shown in that timezone.

Subj.

It was pointed out in #32 that separating lat/lon into two fields vs one makes copy/paste a hassle.

It would be nice if it was possible to copy a properly formatted lat, lon (DD) string from one app, and then paste it filling both fields at once. It would also be nice if copying from either field copied both fields -> lat, lon ready to paste elsewhere.

the app crashes ("unfortunately has stopped") on far northern/southern latitudes on specific dates where a rise/set transition occurs - i.e. a rise/set event occurs one day, but doesn't occur on the next.

tested using v0.2.3 on api19..

• start with clean app installation
• set location to 83.124, 23.1592
• set date to Feb 19. 2017
  --> crashes on apply date

At 83.124, 23.1592, astronomical twilight rises/sets on the 18th, but no longer does so on the 19th. ...should be reproducible with other dates/locations where a similar transition occurs.

Apply GPLv3 header and copyright notice to all source files.

with v0.1.1 dialogs (and their state) were properly retained on orientation change, but from v0.2.0 onward they seem to be lost; the dialogs are now dismissed (as if canceled).

Show a warning icon next to the timezone when daylight savings is observed and in effect.

Ahoi Forrest,
now I've got a proposal: How about using a semantic versioning scheme?

For example, the version bump from 0.1.0 to 0.1.1 could have been a 0.2.0, because you've added i18n.

Greetings
~HerHde

The widget doesn't update the sunrise/sunset times each day without running the app itself.
🔶

The alarm is set incorrectly when the user-defined timezone mismatches the system timezone. The alarm time needs to be converted to the system timezone (same as used by the alarm application).

example: user-defined timezone is set to UTC, the current time is 5:29AM UTC (system time 10:29 MST), the alarm should be set for sunrise at 1:24PM UTC (~6:24AM MST), but instead gets set for 1:24PM MST.

tested on emulator api10.
"Set Date" -> the dialog fails to appear, instead the app crashes.

java.lang.IllegalArgumentException: current should be >= start and <= end
            at android.widget.NumberPicker.setCurrent(NumberPicker.java:288)
            at android.widget.DatePicker.updateDaySpinner(DatePicker.java:397)
            at android.widget.DatePicker.updateSpinners(DatePicker.java:383)
            at android.widget.DatePicker.init(DatePicker.java:379)
            at com.forrestguice.suntimeswidget.TimeDateDialog.initViews(TimeDateDialog.java:126)

values are -1 -1 -1 (init called before values are initialized)
tested on api19 no crash.

I think it would greatly help if the app (haven't tested the widget) would be able to get the location from the network location provider. Currently it will always try and get a GPS fix. This makes it basically useless as long as you are indoors.
The increased error rate should not matter much, as times won't change within a few hundred meters anyway.

The app crashes ("has stopped unexpectedly") when trying to bring up the "data source" preference from "General Settings". Tapping the pref causes the crash (list of choices isn't displayed).

Tested using v0.2.1 w/ api10 (emulator).

On ActionBar -> Settings the app is crashing; the Unfortunately, Suntimes has stopped dialog is displayed.

Tested using v0.2.1 on a Toshiba AT270 (7" tablet) (Android version 4.0.3) (api 15).

Tested on a phone running Android 4.4.2 (api 19).. crash doesn't occur.
Tested on emulator running Android 4.1.1 (api 16) .. crash doesn't occur.

SettingsActivity feature; enabled for "custom location" mode.

Add a button that allows setting the latitude/longitude to a location determined by street address (geocode address -> set lat/lon on UI -> toast).

It seems only 12h format is supported right now. Can 24h format be added into the settings? My phone locale settings is set to 24h by default.

SettingsActivity feature; enabled for "custom location" mode.

Add a button that allows setting the latitude/longitude to the location at configuration time (trigger a one-time location update -> get last known location -> set lat/lon on UI -> toast).

The app calculates the sunrises/sunsets using the standard time of the selected time zone. If the time zone is in daylight savings time (CST vs CDT) the rise/set times are 1 hour off.

Currently using version 0.2.1 via FDroid

Ahoi Forrest,
another one here ;-)
The table in the main activity switches on some events that I would not expect.
It seems to switch between today and tomorrow e.g.:

• when I am on today and click the note with the next note setting and vice versa
• when I am on tomorrow and reactivate my screen or switch back from another app.
• when I am on tomorrow and the clock shows the next minute.

The last two appear intended, what do you say?

Greetings
~HerHde

Implement "current location mode"; the widget always uses the last known location (and receives updates when that location changes).

Create an application icon (svg) suitable for Google Play.
Export png drawables at ldpi, mdpi, hdpi, and xhdpi.

Ahoi,
depending on your latitude, some dusks/twilights don't occur, like up in the north. The english Wikipedia has some Information about this, but your App already correctly shows no Values for e.g. my position:

Could you please set this empty values to none or something, so it doesn't seem broken?

Greetings
~HerHde

Could you add an link to changelog to the fdroid repository? Thanks a lot

Ahoi,
some option names end with a :, some not. I guess this is due the appearance in the widget config, where the names are in the same line as the values.
Could you append the colons to the strings within the widget config, so there are no colons within the translations etc?

Greetings
~HerHde

Ahoi Forrest!
The note displays some wrong durations, when a user defined date is set. It seems to use the difference between the selected date and today's dusks etc.

Examples:

• Date is set to 2016-07-25, it shows ~2d 14h until sunrise.
• Date is 2016-08-01, ~4d 1h until sunset.

I hope this helps.
Greetings
~HerHde

Add a 'theme editor' activity that allows the user to select options and save them as a 'named theme'.

• action: save to theme name OR autosave unsaved changes as "user defined"
• action: export themes to xml
• action: import themes from xml
• UI: background drawable (or color)
• UI: background color selector
• UI: background transparency selector
• UI: background corners selector
• UI: title size selector
• UI: title color selector

Manually editing the lat/lon is potentially confusing because the "push marker" button used to start editing is easily confused as just an icon, and touching the disabled edittext currently does nothing.

The button could look more like a button, but its also intuitive that touching the fields should start editing.

from #32

ActionBar -> Settings -> Active Widgets transitions to a blank screen when using api10 (tested in emulator). Pressing back from blank screen navigates back to the SettingsActivity.