formatterkit / dayperiodformatter Goto Github PK

Currently, DayPeriodFormatter only uses a locale's language code to determine the day period string. However, some rule sets have regional variations, such as es_cO, for "Spanish (Colombia)". These should be selected for matching locales.

This should be as straightforward as changing the current implementation to make two checks, first with and then without the region code. The only real trick is matching the identifier format for case and punctuation (e.g. Locale.identifier BCP 47 es-CO -> CLDR key es_co)

I could imagine consumers of this library wanting to ignore fixed periods when getting the string for a day period in certain locales. Although I wouldn't necessarily advise this usage, someone might prefix the English language day period with the word "Good" as a greeting to users ("Good morning", "Good afternoon", etc.). Without filtering on fixed periods, this would lead to awkward constructions like "Good noon" and "Good midnight".

Implementation-wise, this would involve the following:

• Adding a new property to DayPeriodFormatter (naming is probably the hardest part of this feature)
• Updating DayPeriodRuleSet.period(for:) to take a second parameter to pass the aforementioned property value to conditionally ignore any fixed period for a given hour.