Empty blacklist entries block script about fp-ngfw-smc-python HOT 4 CLOSED

Erratum, my fix is not good.
It's more something like that :

iteration = 0
with SMCSocketProtocol(self, **self.sockopt) as protocol:
    for result in protocol.receive():
        if 'records' in result:
            if result['records']['added'] != []:
                yield result['records']['added']
                iteration += 1
        else:
            yield from ()
            iteration += 1
        if iteration == max_recv:
            protocol.abort()

from fp-ngfw-smc-python.

Ok, the problem was how i used the function.
When we call "query.fetch_as_element()" for BlacklistQuery, we must send the argument "max_recv=1" for example.
With that, we don't hang endlessly.

from fp-ngfw-smc-python.

You can use parameters to customize websocket results:
1 - max_recv : the number of record you want to retrieve, fetch_as_element will return after
2 - query_timeout: the inactivity period in second after the method will return

In this example, the method will return after 10 seconds of inactivity during record reception (or if blacklist entries is empty)

    print("Retrieve all BlacklistEntry elements using smc_monitoring")
    query = BlacklistQuery(ENGINENAME)
    for element in query.fetch_as_element(max_recv=5, query_timeout=10):
        print("{} {} {} {} {} {}".format(element.engine,
                                         element.href,
                                         element.source,
                                         element.destination,
                                         element.protocol,
                                         element.duration))

Tell me if that could solve your problem.
I am going to try your fix suggestion

Thomas

from fp-ngfw-smc-python.

Hello Thomas,
Thanks for your reply.
Yes, it's solve my problem. I'm pretty noob about functions and websocket using yields statement. So i was not prepared about the blacklist function that hang if we received nothing.

Thank you for your help.

Regards, Chris.

from fp-ngfw-smc-python.