Giter Club home page Giter Club logo

Comments (4)

floatingpurr avatar floatingpurr commented on May 24, 2024 1

I see. Thanks for sharing this suggestion. Currently I can't work on it. I'll leave this issue open for future improvements or PRs.

from sync_with_poetry.

ewjoachim avatar ewjoachim commented on May 24, 2024 1

So hm, I wanted to see how hard it would be to work on that. I realized that implementing this would be almost as complex than the original hook. And then looked at how this hook is implemented (I had forgotten that we once had a discussion on that), so I tried doing it the way I had in mind, and... Pretty much ended up with my own pair of hooks (which uses ruamel's roundtrip and uses poetry itself for parsing poetry files).

I added your name in the credits and the license, as your project clearly is a big inspiration :)

from sync_with_poetry.

ewjoachim avatar ewjoachim commented on May 24, 2024

Note: on some of my projects, I've made a script that does this, but I haven't integrated it as a pre-commit hook by itself: https://github.com/procrastinate-org/procrastinate/blob/main/scripts/pre-commit-pyright
One of the reasons is that it's hard to extract raw data from poetry files, so I'm afraid my script is brittle because it relies on parsing stdout outputs designed for humans.

I think it would feel less over-engineered if it was a part of this hook (or another hook altogether, but the concept is so close that it would require maintaining almost the same project twice)
(it could also be a different hook, but maintained in this repo)

from sync_with_poetry.

floatingpurr avatar floatingpurr commented on May 24, 2024

You are too good to me. As I mentioned in the readme, swp is inspired, in turn, by pre-commit autoupdate. Thanx :)

from sync_with_poetry.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.