Comments (3)
Ok I see. +1 for the pre-commit.ci integration but since my system hook runs poetry run
, which activates a virtual environment, I don’t think a lot of the problems with the system hooks don’t happen, eg I know exactly which mypy executable gets called in the example above.
from sync_with_poetry.
Yes. Personally, I prefer to rely on the pre-commit framework for many reasons, e.g., QA in CI/CD pipelines. As you mentioned, you can do the same job with poetry run
in a local fashion. Maybe with an easier setup, but with some limitations.
from sync_with_poetry.
It depends on your needs. You can definitely work that way, but:
"[...] this defeats the purpose of the framework entirely, but it enable some amount of legacy compatibility in some use cases."
(read more about it in this SO answer by Anthony Sottile)
PS: System hooks do not play nicely with https://pre-commit.ci/ and you need to skip them
sync_with_poetry/.pre-commit-config.yaml
Lines 1 to 15 in b447d2e
from sync_with_poetry.
Related Issues (10)
- Run sync_with_poetry after changing the .pre-commit.config.yaml HOT 11
- [Question] Does this work with plugins? HOT 1
- Allow passing in custom db HOT 1
- Request: Sync rev of sync_with_poetry and poetry HOT 6
- FR: Strip `frozen: x.x.x` comments HOT 5
- Poetry 1.5.0 removes category field. HOT 9
- Feature request: static checks dependencies HOT 4
- Autoupdate for flake8 does not work HOT 3
- Matching seems to fails when revision has double quotes HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sync_with_poetry.