Giter Club home page Giter Club logo

Comments (3)

lorenzwalthert avatar lorenzwalthert commented on May 28, 2024 1

Ok I see. +1 for the pre-commit.ci integration but since my system hook runs poetry run, which activates a virtual environment, I don’t think a lot of the problems with the system hooks don’t happen, eg I know exactly which mypy executable gets called in the example above.

from sync_with_poetry.

floatingpurr avatar floatingpurr commented on May 28, 2024 1

Yes. Personally, I prefer to rely on the pre-commit framework for many reasons, e.g., QA in CI/CD pipelines. As you mentioned, you can do the same job with poetry run in a local fashion. Maybe with an easier setup, but with some limitations.

from sync_with_poetry.

floatingpurr avatar floatingpurr commented on May 28, 2024

It depends on your needs. You can definitely work that way, but:

"[...] this defeats the purpose of the framework entirely, but it enable some amount of legacy compatibility in some use cases."

(read more about it in this SO answer by Anthony Sottile)

PS: System hooks do not play nicely with https://pre-commit.ci/ and you need to skip them

ci:
skip: [sync]
minimum_pre_commit_version: 2.15.0
repos:
# sync (use this repo code)
- repo: local
hooks:
- id: sync
name: sync with poetry
entry: poetry run swp
language: system
# need to be explicit with `files`, since we are not using the .pre-commit-hooks.yaml here
files: poetry.lock

from sync_with_poetry.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.