Poetry 1.5.0 removes category field. about sync_with_poetry HOT 9 CLOSED

Thank you @real-yfprojects for your notice. It looks like that poetry 1.5.0 relies on poetry-core 1.6.0 that deprecates Package.category.

I'm not using the newer versions of Poetry on a daily basis. AFAIU from the doc, now there's no way to infer whether the dependency is a "dev dependency" or not from the lock file. Now, this kind of info is managed by dependency groups in the toml file (I guess this holds since poetry 1.2.0).

As per the doc of poetry 1.5.0:

Poetry will slowly transition away from the dev-dependencies notation which will soon be deprecated, so it’s advised to migrate your existing development dependencies to the new group notation.

I'm open to discussions (and contributions) about it.

from sync_with_poetry.

AFAIU from the doc, now there's no way to infer whether the dependency is a "dev dependency" or not from the lock file.

Why do you need that in the first place?

from sync_with_poetry.

There's no hard need. It is just the current way used by swp to check if a package is a "dev dependency". The newer versions of poetry rely on the broader concept of dependency groups. The dependency group of each package has been abstracted away from poetry.lock. That's correct, IMO. However, this changes how this package has to check the dependency type.

from sync_with_poetry.

I mean why do you differentiate between dev and non dev dependencies? If it is used in .pre-commit-config.yaml it should be synced with poetry no matter what.

from sync_with_poetry.

Oh, I'm sorry, I didn't get your question.

I introduced the --all option at the very beginning of the story of this package. It was supposed to be just a kind of a little optimization for going through the collection of PreCommitRepo objects. Indeed, in most cases, .pre-commit is used only with dev packages. Usually, your business packages are not part of the pre-commit process. But this is not a relevant (or even a good) design, even more so now with these changes introduced in poetry.

You are right, the quickest fix could by simply considering poetry.lock as a whole, without caring anymore about the package type.

from sync_with_poetry.

New release brach tracked in #27.

from sync_with_poetry.

👍 Thanks. I can do a quick review later this week if you like.

from sync_with_poetry.

from sync_with_poetry.

Ok, the fix is ready to ship, baked in version 1.0.0.

from sync_with_poetry.